Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded exports in syntax::parse::parser #3726

Closed
catamorphism opened this issue Oct 11, 2012 · 2 comments
Closed

Remove unneeded exports in syntax::parse::parser #3726

catamorphism opened this issue Oct 11, 2012 · 2 comments
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

parser re-exports parse::parse_from_source_str because the #ast macro uses it. With pub/priv, the #ast code could just call it directly and this extra declaration could be removed. I tried to fix the exports, but ran into problems.
@catamorphism
Copy link
Contributor Author

Not critical for 0.6, de-milestoning

@catamorphism
Copy link
Contributor Author

Seems to be fixed now.

@h-michael h-michael mentioned this issue Feb 3, 2019
Merged
bors added a commit that referenced this issue Feb 3, 2019
@bors
Auto merge of #58093 - h-michael:clippy, r=Xanewok
e858c26 
submodule: update clippy from 6ce78d1 to 3bda548

rust-lang/rust-clippy@6ce78d1...3bda548

Rustup: unused trim result
Auto merge of #3727 - phansch:rustup_unused_trim, r=matthiaskrgr  …
Travis: Don't run integration tests on every PR commit  …
Auto merge of #3726 - phansch:some_renaming, r=oli-obk  …
Fix ICE in vec_box lint and add run-rustfix  …
Make vec_box MachineApplicable
Remove conditionals from base builds  …
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100.  …
Running util/dev to update README/CHANGELOG
Reworking function logic, and adding doc example.  …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Skipping check if in external macro.
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100.  …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Changing single character string to a character match.
Updated readme.
Updating code to ignore rustfmt issue.
phansch and avborhanian
Update clippy_lints/src/types.rs  …
Update clippy_lints/src/types.rs  …
Auto merge of #3732 - phansch:fix_ice_3720, r=oli-obk  …
Auto merge of #3731 - phansch:travis, r=phansch  …
Auto merge of #2857 - avborhanian:master, r=phansch  …
Fix breakage due to #58079  …
Auto merge of #3736 - mikerite:fix-build-20190203, r=phansch  …

related with: #58024
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@calebcartwright @topecongiro
fix: issue with --all when workspace member also exists in dep tree (r…
afc8fbd 
…ust-lang#3726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catamorphism