Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight-1.0.0 doesn't build on 1.16 beta #39806

Closed
brson opened this Issue Feb 14, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@brson
Copy link
Contributor

brson commented Feb 14, 2017

https://github.com/neunenak/hilite ac0768130d52219a247d383285ac4adb88d8d1f0

   Compiling getopts v0.2.14
   Compiling hilite v1.0.0 (file:///mnt2/dev/hilite)
error[E0277]: the trait bound `&&[std::string::String]: std::iter::Iterator` is not satisfied
  --> src/main.rs:83:32
   |
83 |                               .args(& program_args)
   |                                ^^^^ the trait `std::iter::Iterator` is not implemented for `&&[std::string::String]`
   |
   = note: `&&[std::string::String]` is not an iterator; maybe try calling `.iter()` or a similar method
   = note: required because of the requirements on the impl of `std::iter::IntoIterator` for `&&[std::string::String]`

error: aborting due to previous error

error: Could not compile `hilite`.

To learn more, run the command again with --verbose.
rustc 1.16.0-beta.1 (5276ba72e 2017-01-31)
binary: rustc
commit-hash: 5276ba72e8fe13597200254447fce9cb3783c583
commit-date: 2017-01-31
host: x86_64-unknown-linux-gnu
release: 1.16.0-beta.1
LLVM version: 3.9

cc @neunenak

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 14, 2017

This also affects http2hpack-0.1.3 and lsio-0.1.16 cc @lambdastackio

@malbarbo

This comment has been minimized.

Copy link
Contributor

malbarbo commented Feb 14, 2017

This also affects rustup

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 14, 2017

"expected" breakage from #38856 I believe

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 14, 2017

Also read-process-memory-0.1.0 and renv-0.2.2 cc @luser @cmsd2

@luser

This comment has been minimized.

Copy link
Contributor

luser commented Feb 15, 2017

read-process-memory was a trivial fix to a test: luser/read-process-memory@28a887f . Thanks for the heads up!

@cmsd2

This comment has been minimized.

Copy link

cmsd2 commented Feb 15, 2017

@arielb1 arielb1 added T-libs and removed T-compiler labels Feb 16, 2017

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Feb 16, 2017

This is expected inference breakage - moving to T-libs.

@luser

This comment has been minimized.

Copy link
Contributor

luser commented Feb 17, 2017

I published read-process-memory 0.1.1 with the fix.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 28, 2017

Discussed during libs triage today the conclusion was that this falls under "acceptable API evolution", so we're not going to revert. If any assistance is needed though in updating crates, please let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.