Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: test --stage 1 src/test/ui builds "stage1 compiler artifacts" #40016

Closed
petrochenkov opened this issue Feb 21, 2017 · 3 comments
Closed
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@petrochenkov
Copy link
Contributor

while other useful stage 1 tests like compile-fail or run-pass will happily run after building only "stage1 std artifacts".

compile-fail and ui are inseparable and need to be tested together and building "stage1 compiler artifacts" makes the edit-compile-test cycle ~twice longer.

@petrochenkov petrochenkov added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 21, 2017
@alexcrichton
Copy link
Member

To do this we'd have to split the ui test suite between "requires only std" and "requires more than std". I believe there's one test which requires plugins, which needs to build the whole compiler

@petrochenkov
Copy link
Contributor Author

Like compile-fail-fulldeps, but ui-fulldeps? (If understand the purpose of fulldeps tests correctly.)

@alexcrichton
Copy link
Member

Indeed!

frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 3, 2017
bors added a commit that referenced this issue Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants