Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for str_mut_extras and str_box_extras #41119

Closed
clarfonthey opened this issue Apr 6, 2017 · 6 comments
Closed

Tracking issue for str_mut_extras and str_box_extras #41119

clarfonthey opened this issue Apr 6, 2017 · 6 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Apr 6, 2017 •
edited
Loading

cc @alexcrichton @sfackler

PRs: #41096 and #41258 respectively

Notes:

  • Are the naming conventions for these methods correct?
@clarfonthey clarfonthey changed the title Tracking issue for str::from_utf8_unchecked_mut and str::as_bytes_mut Tracking issue for str::from_utf8_mut and str::as_bytes_mut Apr 6, 2017
@sfackler sfackler added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 7, 2017
@clarfonthey clarfonthey changed the title Tracking issue for str::from_utf8_mut and str::as_bytes_mut Tracking issue for str_mut_extras and str_box_extras Apr 12, 2017
@clarfonthey clarfonthey mentioned this issue Apr 14, 2017
Open
@alexbool
Copy link
Contributor

What holds stabilization of these methods right now?

@SimonSapin
Copy link
Contributor

@aturon @alexcrichton FCP to stabilize?

@aturon
Copy link
Member

aturon commented Jul 3, 2017

@rfcbot fcp merge

Covered APIs include:

  • as_bytes_mut
  • from_utf8_mut
  • from_utf8_unchecked_mut
  • <Box<str>>::into_boxed_bytes (just calls Into::into)
  • from_boxed_utf8 and from_boxed_utf8_unchecked, defined in alloc:str, exported in collections::str
  • exports from_utf8_mut in collections::str (missed from previous PR)

@rfcbot
Copy link

rfcbot commented Jul 3, 2017 •
edited by BurntSushi
Loading

Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 3, 2017
@dtolnay
Copy link
Member

dtolnay commented Jul 18, 2017

from_boxed_utf8 no longer exists. #41258 (comment)

@rfcbot reviewed

@rfcbot
Copy link

rfcbot commented Jul 20, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 20, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 22, 2017
@bors bors closed this as completed in 16707d4 Jul 27, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this issue Aug 12, 2017
@alexcrichton
std: Stabilize the str_{mut,box}_extras feature
a2b8556 
Stabilizes

* `<&mut str>::as_bytes_mut`
* `<Box<str>>::into_boxed_bytes`
* `std::str::from_boxed_utf8_unchecked`
* `std::str::from_utf8_mut`
* `std::str::from_utf8_unchecked_mut`

Closes rust-lang#41119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@SimonSapin @aturon @alexbool @sfackler @dtolnay @Mark-Simulacrum @clarfonthey @rfcbot