Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rls --version #41197

Closed
alexcrichton opened this issue Apr 10, 2017 · 7 comments · Fixed by #42146
Closed

Support rls --version #41197

alexcrichton opened this issue Apr 10, 2017 · 7 comments · Fixed by #42146
Labels
T-core Relevant to the core team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Right now the rls executable we're going to start shipping doesn't support rls --version, but we've got a relatively standard format between rls/cargo that should be supported. Cargo's looks like this and we probably want the RLS logic to look similar.
@alexcrichton alexcrichton added this to the 1.19 milestone Apr 10, 2017
@alexcrichton
Copy link
Member Author

cc #40584, @nrc, @jonathandturner

(you may wish to open a tracking issue in the rls repo to track this)

@alexcrichton alexcrichton modified the milestones: 1.18, 1.19 Apr 10, 2017
@alexcrichton alexcrichton modified the milestones: 1.17, 1.18, 1.19 May 4, 2017
@tetsuharuohzeki tetsuharuohzeki mentioned this issue May 10, 2017
Closed
@nrc nrc mentioned this issue May 10, 2017
Closed
6 tasks
@sophiajt
Copy link
Contributor

The RLS currently has a --version flag. Is this bug tracking it landing in rustup?

@sophiajt
Copy link
Contributor

(lol, just noticed the date of the bug...)

@alexcrichton
Copy link
Member Author

Aha yep! Just ran this:

$ rls +nightly --version
rls 0.1.0 (38ca9b7 2017-05-14)

Looks great to me! The only missing piece I believe is the "-nightly" or "-beta" piece. @jonathandturner do you know the right person to cc about that?

@sophiajt
Copy link
Contributor

I'd CC @nrc since he's overseeing RLS and can handle it

@nrc
Copy link
Member

nrc commented May 16, 2017

I added -nightly to the version string. The RLS is always nightly for now since we are not going though beta, etc. at the moment. Is that going to work for Rustbuild?

The RLS currently has a --version flag. Is this bug tracking it landing in rustup?

AIUI Rustbuild should actually use the flag, rather than do whatever placeholder thing it does at the moment.

@alexcrichton
Copy link
Member Author

Ok thanks @nrc! It sounds like we're going to discuss more of the stability story for the rls soon anyway? May be best to defer some of this to then if so.

@nrc nrc mentioned this issue May 22, 2017
Merged
@brson brson removed this from the 1.19 milestone Jun 1, 2017
@Mark-Simulacrum Mark-Simulacrum added the T-core Relevant to the core team, which will review and decide on the PR/issue. label Jun 23, 2017
bors added a commit that referenced this issue Jul 10, 2017
@bors
Auto merge of #42146 - nrc:rls-rust, r=@alexcrichton
d3e384f 
More Rust/RLS integration

r? @alexcrichton

cc rust-lang/rls#310

closes #41199
closes #41197
bors added a commit that referenced this issue Jul 17, 2017
@bors
Auto merge of #42146 - nrc:rls-rust, r=alexcrichton
88cf76a 
More Rust/RLS integration

r? @alexcrichton

cc rust-lang/rls#310

closes #41199
closes #41197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-core Relevant to the core team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More Rust/RLS integration nrc/rust
5 participants
@alexcrichton @brson @sophiajt @nrc @Mark-Simulacrum