Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `rls --version` #41197

Closed
alexcrichton opened this Issue Apr 10, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@alexcrichton
Copy link
Member

alexcrichton commented Apr 10, 2017

Right now the rls executable we're going to start shipping doesn't support rls --version, but we've got a relatively standard format between rls/cargo that should be supported. Cargo's looks like this and we probably want the RLS logic to look similar.

@alexcrichton alexcrichton added this to the 1.19 milestone Apr 10, 2017

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Apr 10, 2017

cc #40584, @nrc, @jonathandturner

(you may wish to open a tracking issue in the rls repo to track this)

@alexcrichton alexcrichton modified the milestones: 1.18, 1.19 Apr 10, 2017

@alexcrichton alexcrichton modified the milestones: 1.17, 1.18, 1.19 May 4, 2017

@nrc nrc referenced this issue May 10, 2017

Closed

tracking issue: distribution #310

5 of 6 tasks complete
@jonathandturner

This comment has been minimized.

Copy link
Contributor

jonathandturner commented May 14, 2017

The RLS currently has a --version flag. Is this bug tracking it landing in rustup?

@jonathandturner

This comment has been minimized.

Copy link
Contributor

jonathandturner commented May 14, 2017

(lol, just noticed the date of the bug...)

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented May 15, 2017

Aha yep! Just ran this:

$ rls +nightly --version
rls 0.1.0 (38ca9b7 2017-05-14)

Looks great to me! The only missing piece I believe is the "-nightly" or "-beta" piece. @jonathandturner do you know the right person to cc about that?

@jonathandturner

This comment has been minimized.

Copy link
Contributor

jonathandturner commented May 15, 2017

I'd CC @nrc since he's overseeing RLS and can handle it

@nrc

This comment has been minimized.

Copy link
Member

nrc commented May 16, 2017

I added -nightly to the version string. The RLS is always nightly for now since we are not going though beta, etc. at the moment. Is that going to work for Rustbuild?

The RLS currently has a --version flag. Is this bug tracking it landing in rustup?

AIUI Rustbuild should actually use the flag, rather than do whatever placeholder thing it does at the moment.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented May 16, 2017

Ok thanks @nrc! It sounds like we're going to discuss more of the stability story for the rls soon anyway? May be best to defer some of this to then if so.

@brson brson removed this from the 1.19 milestone Jun 1, 2017

bors added a commit that referenced this issue Jul 1, 2017

bors added a commit that referenced this issue Jul 10, 2017

bors added a commit that referenced this issue Jul 10, 2017

bors added a commit that referenced this issue Jul 11, 2017

bors added a commit that referenced this issue Jul 13, 2017

bors added a commit that referenced this issue Jul 17, 2017

@bors bors closed this in #42146 Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.