Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport `rls --version` #41197
Comments
alexcrichton
added this to the 1.19 milestone
Apr 10, 2017
This comment has been minimized.
This comment has been minimized.
|
cc #40584, @nrc, @jonathandturner (you may wish to open a tracking issue in the rls repo to track this) |
alexcrichton
modified the milestones:
1.18,
1.19
Apr 10, 2017
alexcrichton
modified the milestones:
1.17,
1.18,
1.19
May 4, 2017
This comment has been minimized.
This comment has been minimized.
|
The RLS currently has a --version flag. Is this bug tracking it landing in rustup? |
This comment has been minimized.
This comment has been minimized.
|
(lol, just noticed the date of the bug...) |
This comment has been minimized.
This comment has been minimized.
|
Aha yep! Just ran this:
Looks great to me! The only missing piece I believe is the "-nightly" or "-beta" piece. @jonathandturner do you know the right person to cc about that? |
This comment has been minimized.
This comment has been minimized.
|
I'd CC @nrc since he's overseeing RLS and can handle it |
This comment has been minimized.
This comment has been minimized.
|
I added
AIUI Rustbuild should actually use the flag, rather than do whatever placeholder thing it does at the moment. |
This comment has been minimized.
This comment has been minimized.
|
Ok thanks @nrc! It sounds like we're going to discuss more of the stability story for the rls soon anyway? May be best to defer some of this to then if so. |
alexcrichton commentedApr 10, 2017
Right now the
rlsexecutable we're going to start shipping doesn't supportrls --version, but we've got a relatively standard format between rls/cargo that should be supported. Cargo's looks like this and we probably want the RLS logic to look similar.