Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Drop behavior of ChildStd[in, out, err] #41452

Closed
abonander opened this issue Apr 21, 2017 · 1 comment
Closed

Document Drop behavior of ChildStd[in, out, err] #41452

abonander opened this issue Apr 21, 2017 · 1 comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority

Comments

@abonander
Copy link
Contributor

abonander commented Apr 21, 2017 •
edited
Loading

Piped child process I/O streams are implicitly closed on-drop (via Drop impls on the OS file descriptor wrappers), but this is not documented anywhere, giving the impression that there's no safe way to close these streams.

This is causing some confusion in the wild (https://www.reddit.com/r/rust/comments/65txlh/_/dgi86yp), so we should note this behavior in the docs for ChildStd[in, out, err].
@abonander abonander changed the title Document Drop behavior of ChildStd* Document Drop behavior of ChildStd[in, out, err] Apr 21, 2017
@Mark-Simulacrum Mark-Simulacrum added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Apr 21, 2017
@steveklabnik steveklabnik added the P-medium Medium priority label Apr 26, 2017
@abonander abonander mentioned this issue May 15, 2017
Closed
14 tasks
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 27, 2017
@frewsxcv frewsxcv mentioned this issue Sep 16, 2017
Merged
@frewsxcv
Copy link
Member

Opened a PR for this: #44625

frewsxcv added a commit to frewsxcv/rust that referenced this issue Sep 16, 2017
@frewsxcv
Indicate how ChildStd{in,out,err} FDs are closed.
a6ef99e 
Fixes rust-lang#41452.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 23, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44625 - frewsxcv:frewsxcv-raii-stdin, r=Qui…
3426bf0 
…etMisdreavus

Indicate how ChildStd{in,out,err} FDs are closed.

Fixes rust-lang#41452.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 24, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44625 - frewsxcv:frewsxcv-raii-stdin, r=Qui…
b1a1861 
…etMisdreavus

Indicate how ChildStd{in,out,err} FDs are closed.

Fixes rust-lang#41452.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @frewsxcv @abonander @Mark-Simulacrum