New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustdoc no longer part of distributable #43729

Closed
nrc opened this Issue Aug 8, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@nrc
Member

nrc commented Aug 8, 2017

librustdoc used to be distributed with other compiler crates and could be found in the sysroot. This is no longer the case which breaks any crate which does extern crate rustdoc;.

I assume this wasn't intentional and is due to the changes with how rustdoc is being built.

cc @Mark-Simulacrum @alexcrichton

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Aug 8, 2017

Member

Hm this was indeed intentional, all due to #43482. That being said, it wasn't intended to break things!

@nrc did you have tools using extern crate rustdoc out of tree? That's sort of something I'd hope that we wouldn't have to keep working :(

Member

alexcrichton commented Aug 8, 2017

Hm this was indeed intentional, all due to #43482. That being said, it wasn't intended to break things!

@nrc did you have tools using extern crate rustdoc out of tree? That's sort of something I'd hope that we wouldn't have to keep working :(

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Aug 8, 2017

Member

Yes, this was indeed intentional. We can technically fix this I think if we need to, but I'd prefer not to -- it'd be a bit of a hack.

Member

Mark-Simulacrum commented Aug 8, 2017

Yes, this was indeed intentional. We can technically fix this I think if we need to, but I'd prefer not to -- it'd be a bit of a hack.

@nrc

This comment has been minimized.

Show comment
Hide comment
@nrc

nrc Aug 8, 2017

Member

did you have tools using extern crate rustdoc out of tree?

Yes, rustw does. It only uses its markdown rendering though. I'd assume I could pull that into an external crate, but iirc, the last time I tried that it was tied into rustdoc and compiler internals in weird ways.

I'll look into that - I assume Steve will have to solve a similar problem for new rustdoc, so maybe I can use that?

Member

nrc commented Aug 8, 2017

did you have tools using extern crate rustdoc out of tree?

Yes, rustw does. It only uses its markdown rendering though. I'd assume I could pull that into an external crate, but iirc, the last time I tried that it was tied into rustdoc and compiler internals in weird ways.

I'll look into that - I assume Steve will have to solve a similar problem for new rustdoc, so maybe I can use that?

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Aug 9, 2017

Member

Well, if it's not working out to migrate to either the new rustdoc or otherwise solve the problem, let us know and we can discuss making librustdoc remain in the sysroot.

Member

Mark-Simulacrum commented Aug 9, 2017

Well, if it's not working out to migrate to either the new rustdoc or otherwise solve the problem, let us know and we can discuss making librustdoc remain in the sysroot.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Sep 15, 2017

Member

@rfcbot fcp close

Let's see if this works...

If not, I'll just close; I don't think this is going to change. rustdoc is unstable, and shouldn't really be used for markdown rendering anyway...

Member

Mark-Simulacrum commented Sep 15, 2017

@rfcbot fcp close

Let's see if this works...

If not, I'll just close; I don't think this is going to change. rustdoc is unstable, and shouldn't really be used for markdown rendering anyway...

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Sep 15, 2017

Team member @Mark-Simulacrum has proposed to close this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Sep 15, 2017

Team member @Mark-Simulacrum has proposed to close this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 15, 2017

Member

I assume Steve will have to solve a similar problem for new rustdoc

I was planning on publishing on crates.io, honestly.

Member

steveklabnik commented Sep 15, 2017

I assume Steve will have to solve a similar problem for new rustdoc

I was planning on publishing on crates.io, honestly.

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Feb 16, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Feb 16, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Feb 26, 2018

The final comment period is now complete.

rfcbot commented Feb 26, 2018

The final comment period is now complete.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Jun 12, 2018

Member

Closing as per concluded FCP.

Member

Mark-Simulacrum commented Jun 12, 2018

Closing as per concluded FCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment