New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 2296, `Option::replace` #51998

Closed
Centril opened this Issue Jul 2, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@Centril
Contributor

Centril commented Jul 2, 2018

This is a tracking issue for the RFC "Add Option::replace to the core library" (rust-lang/rfcs#2296).

Steps:

Unresolved questions:

None

kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018

Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 13, 2018

Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).

kennytm added a commit to kennytm/rust that referenced this issue Jul 13, 2018

Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).

@Centril Centril added the B-unstable label Sep 18, 2018

@Centril

This comment has been minimized.

Contributor

Centril commented Sep 18, 2018

cc @SimonSapin this has baked in nightly for roughly 9.5 weeks; should we stabilize?

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Sep 18, 2018

Looks good to me.

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

rfcbot commented Sep 18, 2018

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

rfcbot commented Sep 19, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

rfcbot commented Sep 29, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@Centril

This comment has been minimized.

Contributor

Centril commented Oct 7, 2018

@Kerollmops would you be willing to write up a stabilization PR?

@Kerollmops

This comment has been minimized.

Contributor

Kerollmops commented Oct 7, 2018

Yes, I will do that !

pietroalbini added a commit to pietroalbini/rust that referenced this issue Oct 9, 2018

Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.

pietroalbini added a commit to pietroalbini/rust that referenced this issue Oct 10, 2018

Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.

Manishearth added a commit to Manishearth/rust that referenced this issue Oct 10, 2018

Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.

Manishearth added a commit to Manishearth/rust that referenced this issue Oct 10, 2018

Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.
@Centril

This comment has been minimized.

Contributor

Centril commented Oct 31, 2018

I believe there's nothing more left to do; closing therefore.

@Centril Centril closed this Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment