Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc repeats implementation 13 times #53689

Closed
Centril opened this issue Aug 25, 2018 · 2 comments
Closed

rustdoc repeats implementation 13 times #53689

Centril opened this issue Aug 25, 2018 · 2 comments
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Aug 25, 2018

This has probably already been filed... but rustdoc displays an impl 13 times here.
@Centril Centril added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Aug 25, 2018
@GuillaumeGomez
Copy link
Member

We weren't sure once was enough. :D

@GuillaumeGomez
Copy link
Member

It actually allowed me to see more UI bugs. Opening an issue for those ones.

@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 29, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Sep 1, 2018
@kennytm
Rollup merge of rust-lang#53801 - GuillaumeGomez:duplicated-foreign-t…
f370814 
…ype-impls, r=QuietMisdreavus

Prevent duplicated impl on foreign types

Fixes rust-lang#53689.

r? @QuietMisdreavus
This was referenced Sep 9, 2018
Merged
Merged
kennytm added a commit to kennytm/rust that referenced this issue Sep 12, 2018
@kennytm
Rollup merge of rust-lang#54087 - ollie27:rustdoc_blanket_impl, r=Qui…
40d9740 
…etMisdreavus

rustdoc: Remove generated blanket impls from trait pages

rust-lang#53801 only deduped the generated blanket impls but they shouldn't be displayed at all because the original blanket impl is already in the "Implementors" section. This also removes the impls from the sidebar.

Fixes rust-lang#53689

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @GuillaumeGomez