Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 2451, "Re-Rebalancing Coherence" #55437

Closed
Centril opened this issue Oct 28, 2018 · 10 comments

Comments

@Centril
Copy link
Member

@Centril Centril commented Oct 28, 2018

This is a tracking issue for the RFC "Re-Rebalancing Coherence" (rust-lang/rfcs#2451).

Steps:

Unresolved questions:

  • Are there additional implementations which are clearly acceptable under the current restrictions, which are disallowed with this extension? Should we allow them if so?
bors added a commit that referenced this issue Jan 3, 2019
Implement the Re-rebalance coherence RFC

This is the first time I touch anything in the compiler so just tell me if I got something wrong.

Big thanks to @sgrif for the pointers where to look for those things.
cc #55437
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jan 3, 2019
…nikomatsakis

Implement the Re-rebalance coherence RFC

This is the first time I touch anything in the compiler so just tell me if I got something wrong.

Big thanks to @sgrif for the pointers where to look for those things.
cc rust-lang#55437
bors added a commit that referenced this issue Jan 5, 2019
Implement the Re-rebalance coherence RFC

This is the first time I touch anything in the compiler so just tell me if I got something wrong.

Big thanks to @sgrif for the pointers where to look for those things.
cc #55437
@dwijnand

This comment has been minimized.

Copy link
Member

@dwijnand dwijnand commented Jan 10, 2019

Implemented in #56145.

@weiznich

This comment has been minimized.

Copy link
Contributor

@weiznich weiznich commented Jan 22, 2019

To just add a implementation example:
We've used this feature to improve the implementation of diesel-oci. For this use case it seems to work fine.

@Centril Somebody needs to update the boxes in the opening comment and change the label to B-RFC-implemented.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

@nikomatsakis nikomatsakis commented May 30, 2019

We discussed this some time back and the plan was for me to write a stabilization report. But I've not done so. I do expect to do so, but perhaps not for a week or two.

@pmarks

This comment has been minimized.

Copy link

@pmarks pmarks commented May 31, 2019

@nikomatsakis in case it's useful: vbarrielle/sprs#160

ndarray::Dot is a trait similar to Mul but for matrix multiplication. ndarray provides dense matrices and Dot impls for dense matrices. The sprs crate for sparse matrices wants to interoperate with ndarray and provide generic sparse.dot(dense) and dense.dot(sparse) impls. Both are needed since matrix multiplication isn't commutative. We're able to provide impl Dot<sprs::CsMat<_,_>> for ndarray::ArrayBase<_,_> from the sprs crate with this feature. We're looking forward to having it stabilized!!

@djc

This comment has been minimized.

Copy link
Contributor

@djc djc commented Jul 26, 2019

What's the holdup for moving this towards stabilization? Still waiting for a lang team member to write the stabilization report? Is there a template that a non-team member could follow to assist with this work?

@Centril

This comment has been minimized.

Copy link
Member Author

@Centril Centril commented Jul 26, 2019

@djc Niko is on vacation and generally busy so he hasn't had time to write up the report yet. If you want to help out with that, there's inspiration to find in #61682 (comment) (which is my most recent and elaborate report hitherto), #61347 (comment), and #57175. Feel free to reach out to me on Discord's #design channel to discuss your progress / draft.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

@nikomatsakis nikomatsakis commented Aug 15, 2019

@djc see #63599

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

@nikomatsakis nikomatsakis commented Aug 15, 2019

Er, I could have worded that a bit more broadly for everyone. =) #63599 contains a stabilization proposal. Thoughts etc welcome in that issue.

@djc

This comment has been minimized.

Copy link
Contributor

@djc djc commented Aug 18, 2019

@nikomatsakis awesome, thanks! Sorry I couldn't contribute anything in the end.

Centril added a commit to Centril/rust that referenced this issue Sep 20, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
tmandry added a commit to tmandry/rust that referenced this issue Sep 20, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
tmandry added a commit to tmandry/rust that referenced this issue Sep 20, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
tmandry added a commit to tmandry/rust that referenced this issue Sep 20, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
tmandry added a commit to tmandry/rust that referenced this issue Sep 20, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
tmandry added a commit to tmandry/rust that referenced this issue Sep 21, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
Centril added a commit to Centril/rust that referenced this issue Sep 22, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
bors added a commit that referenced this issue Sep 23, 2019
…nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes #64412
Depends/Contains on #64414

cc #55437 and #63599
Centril added a commit to Centril/rust that referenced this issue Sep 24, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
Centril added a commit to Centril/rust that referenced this issue Sep 27, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
Centril added a commit to Centril/rust that referenced this issue Sep 28, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
Centril added a commit to Centril/rust that referenced this issue Sep 28, 2019
…e-tests, r=nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes rust-lang#64412
Depends/Contains on rust-lang#64414

cc rust-lang#55437 and rust-lang#63599
bors added a commit that referenced this issue Sep 29, 2019
…nikomatsakis

Bugfix/rfc 2451 rerebalance tests

r? @nikomatsakis

Fixes #64412
Depends/Contains on #64414

cc #55437 and #63599
@lzutao

This comment has been minimized.

Copy link
Contributor

@lzutao lzutao commented Nov 9, 2019

Stabilized in #65879

@Centril Centril closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.