Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly documentation is broken #57628

Closed
pravic opened this issue Jan 15, 2019 · 4 comments
Closed

Nightly documentation is broken #57628

pravic opened this issue Jan 15, 2019 · 4 comments
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pravic
Copy link
Contributor

pravic commented Jan 15, 2019

Windows, different browsers.

Nightly https://doc.rust-lang.org/nightly/std/path/struct.Path.html#method.is_absolute
Stable https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.is_absolute

Link text is invisible:

image
@pravic
Copy link
Contributor Author

pravic commented Jan 15, 2019

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Nice catch. Will send the patch as soon as I can.

@GuillaumeGomez GuillaumeGomez self-assigned this Jan 15, 2019
@pravic
Copy link
Contributor Author

pravic commented Jan 15, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 15, 2019
Merged
@Centril Centril added O-windows Operating system: Windows T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Jan 16, 2019
@Osspial
Copy link

Osspial commented Jan 17, 2019

This also causes the hyperlinks in the function declaration line to not work.

Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
512bbda 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
1cef86c 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
ff03bcd 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
@Centril Centril mentioned this issue Jan 17, 2019
Closed
fitzgen added a commit to fitzgen/wasm-bindgen that referenced this issue Jan 17, 2019
@fitzgen
ci: build docs on stable
222d5ca 
This avoids rust-lang/rust#57628 and also generally
makes sense since wasm-bindgen buils on stable.
@fitzgen fitzgen mentioned this issue Jan 17, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
67386f0 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
16bcbc5 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 18, 2019
@GuillaumeGomez
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
8569848 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
@Centril
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
b9e940c 
…reavus

Fixes text becoming invisible when element targetted

Fixes rust-lang#57628.

r? @QuietMisdreavus
@hellow554 hellow554 mentioned this issue Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. O-windows Operating system: Windows regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pravic @Centril @GuillaumeGomez @Osspial