Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] trim_start_matches and trim_end_matches have copy+pasted docs #57686

Closed
vitiral opened this issue Jan 17, 2019 · 1 comment · Fixed by #58005
Closed

[docs] trim_start_matches and trim_end_matches have copy+pasted docs #57686

vitiral opened this issue Jan 17, 2019 · 1 comment · Fixed by #58005
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.

Comments

@vitiral
Copy link
Contributor

vitiral commented Jan 17, 2019 •
edited
Loading

trim_start_matches states:

Text directionality

A string is a sequence of bytes. 'Left' in this context means the first position of that byte string; for a language like Arabic or Hebrew which are 'right to left' rather than 'left to right', this will be the right side, not the left.

But "left" is never mentioned XD

Same is true for trim_end_matches.

(Note: copy/pasted from trim_left_matches and trim_right_matches)
@hellow554
Copy link
Contributor

Would you mind to open a PR and fix it? ;)

@Centril Centril added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. labels Jan 17, 2019
vitiral pushed a commit to vitiral/rust that referenced this issue Jan 30, 2019
fix rust-lang#57686: update docs for fix_start/end_matches
4a3caca
@vitiral vitiral mentioned this issue Jan 30, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jan 31, 2019
@Centril
Rollup merge of rust-lang#58005 - vitiral:docs_trim_start_matches, r=…
c76456c 
…Manishearth

update docs for fix_start/end_matches

fixes rust-lang#57686:
@Flast Flast mentioned this issue Jul 3, 2019
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62327 - Flast:patch-1, r=Mark-Simulacrum
6e9a80e 
Fixed document bug, those replaced each other

Originally reported by rust-lang#57686, introduced by rust-lang#58005
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62327 - Flast:patch-1, r=Mark-Simulacrum
6b43b50 
Fixed document bug, those replaced each other

Originally reported by rust-lang#57686, introduced by rust-lang#58005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update docs for fix_start/end_matches vitiral/rust
3 participants
@Centril @hellow554 @vitiral