Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for todo! macro #59277

Open
matklad opened this issue Mar 18, 2019 · 8 comments

Comments

@matklad
Copy link
Member

@matklad matklad commented Mar 18, 2019

This is a tracking issue for todo! macro.

Added in #56348. Feature gate: #![feature(todo_macro)].

When stabilizing, we should adjust documentation for unimplemented! to point towards todo!

@stjepang

This comment has been minimized.

Copy link
Contributor

@stjepang stjepang commented Apr 29, 2019

Anyone wants to FCP for stabilization?

I find this macro so handy I began putting #![feature(todo_macro)] everywhere.

@Centril

This comment has been minimized.

Copy link
Member

@Centril Centril commented May 8, 2019

cc @alexcrichton --^ ?

@stjepang

This comment has been minimized.

Copy link
Contributor

@stjepang stjepang commented Jun 1, 2019

It's been a while -- just a ping in case this slipped through. :)

@matklad

This comment has been minimized.

Copy link
Member Author

@matklad matklad commented Jun 1, 2019

I guess we should submit stabilization PR and run FCP on that? Note that the PR needs to adjust docs for unimplemented as well. I can send the PR, but not immediately: putting out fires in rust-analyzer :D

Centril added a commit to Centril/rust that referenced this issue Oct 3, 2019
…oats

Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: rust-lang#59277

This PR needs a FCP to merge.

r? @withoutboats
bors added a commit that referenced this issue Oct 3, 2019
Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: #59277

This PR needs a FCP to merge.

r? @withoutboats
bors added a commit that referenced this issue Oct 3, 2019
Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: #59277

This PR needs a FCP to merge.

r? @withoutboats
Centril added a commit to Centril/rust that referenced this issue Oct 3, 2019
…oats

Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: rust-lang#59277

This PR needs a FCP to merge.

r? @withoutboats
bors added a commit that referenced this issue Oct 3, 2019
Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: #59277

This PR needs a FCP to merge.

r? @withoutboats
tmandry added a commit to tmandry/rust that referenced this issue Oct 3, 2019
…oats

Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: rust-lang#59277

This PR needs a FCP to merge.

r? @withoutboats
bors added a commit that referenced this issue Oct 3, 2019
Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: #59277

This PR needs a FCP to merge.

r? @withoutboats
tmandry added a commit to tmandry/rust that referenced this issue Oct 3, 2019
…oats

Stabilize todo macro

The `todo!` macro is just another name for `unimplemented!`.

Tracking issue: rust-lang#59277

This PR needs a FCP to merge.

r? @withoutboats
@SimonSapin

This comment has been minimized.

Copy link
Contributor

@SimonSapin SimonSapin commented Oct 18, 2019

I don’t have a strong opinion on this one, but since it landed and there doesn’t seem to be significant issues discussed since:

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

@rfcbot rfcbot commented Oct 18, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

@rfcbot rfcbot commented Oct 21, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

@rfcbot rfcbot commented Oct 31, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.