Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edition should be part of the "short" subset of rustc opts #59361

Closed
peterjoel opened this issue Mar 22, 2019 · 0 comments
Closed

Edition should be part of the "short" subset of rustc opts #59361

peterjoel opened this issue Mar 22, 2019 · 0 comments
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@peterjoel
Copy link
Contributor

The default edition is 2015, but the option to change this in the "extended" list, so it is only discoverable with rustc --help -v, rather than just rustc --help.

Users should be encouraged to use 2018 where possible, but the omission of the edition from the default help list makes it less likely that it will be found for users not using Cargo.
@peterjoel peterjoel mentioned this issue Mar 22, 2019
Merged
@jonas-schievink jonas-schievink added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Mar 22, 2019
@estebank estebank added I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2019
Centril added a commit to Centril/rust that referenced this issue Mar 28, 2019
@Centril
Rollup merge of rust-lang#59363 - peterjoel:issue_59361_edition_opt_s…
f591d25 
…hortlist, r=nagisa

rust-lang#59361 Moved rustc edition opt to short list

Addresses rust-lang#59361, in case that issue is accepted.
@Centril Centril mentioned this issue Mar 28, 2019
Merged
bors added a commit that referenced this issue Mar 28, 2019
@bors
Auto merge of #59487 - Centril:rollup, r=Centril
70a497a 
Rollup of 10 pull requests

Successful merges:

 - #58717 (Add FromStr impl for NonZero types)
 - #59091 (Combine input and eval_always query types)
 - #59216 (Type dependent defs wrappers)
 - #59318 (rustc: Update linker flavor inference from filename)
 - #59320 (rustc: Allow using `clang` for wasm32 targets)
 - #59363 (#59361 Moved rustc edition opt to short list)
 - #59371 (ffi: rename VaList::copy to VaList::with_copy)
 - #59398 (Add a way to track Rustfix UI test coverage)
 - #59408 (compiletest: make path normalization smarter)
 - #59429 (When moving out of a for loop head, suggest borrowing it in nll mode)

Failed merges:

r? @ghost
@bors bors closed this as completed in 3eb4eae Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterjoel @estebank @jonas-schievink