Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#59471 #59477

Closed
rust-highfive opened this issue Mar 28, 2019 · 3 comments
Closed

miri no longer builds after rust-lang/rust#59471 #59477

rust-highfive opened this issue Mar 28, 2019 · 3 comments
Assignees
@cuviper @eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #59471, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @cuviper, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @cuviper, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2019
@RalfJung
Copy link
Member

Fix in progress at rust-lang/miri#668

@pnkfelix
Copy link
Member

T-compiler triage: marking P-high

@pnkfelix pnkfelix added P-high High priority and removed I-nominated labels Mar 28, 2019
@RalfJung RalfJung mentioned this issue Mar 30, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 4, 2019
@Centril
Rollup merge of rust-lang#59555 - RalfJung:miri, r=oli-obk
3ed8795 
update miri

r? @oli-obk

Fixes rust-lang#59477
Centril added a commit to Centril/rust that referenced this issue Apr 4, 2019
@Centril
Rollup merge of rust-lang#59555 - RalfJung:miri, r=oli-obk
c123d2a 
update miri

r? @oli-obk

Fixes rust-lang#59477
Centril added a commit to Centril/rust that referenced this issue Apr 4, 2019
@Centril
Rollup merge of rust-lang#59555 - RalfJung:miri, r=oli-obk
1eec471 
update miri

r? @oli-obk

Fixes rust-lang#59477
Centril added a commit to Centril/rust that referenced this issue Apr 4, 2019
@Centril
Rollup merge of rust-lang#59555 - RalfJung:miri, r=oli-obk
a7de161 
update miri

r? @oli-obk

Fixes rust-lang#59477
Centril added a commit to Centril/rust that referenced this issue Apr 4, 2019
@Centril
Rollup merge of rust-lang#59555 - RalfJung:miri, r=oli-obk
2074c96 
update miri

r? @oli-obk

Fixes rust-lang#59477
@pnkfelix
Copy link
Member

pnkfelix commented Apr 4, 2019

triage: this appears to be well in hand. But also, just to revise precedent to match @RalfJung 's expectations: Revising priority here to P-medium.

@pnkfelix pnkfelix added P-medium Medium priority and removed P-high High priority labels Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuviper cuviper

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cuviper @eddyb @pnkfelix @RalfJung @oli-obk @rust-highfive