Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shipping llvm-rc.exe on windows. #60251

Open
crlf0710 opened this issue Apr 25, 2019 · 4 comments
Open

Consider shipping llvm-rc.exe on windows. #60251

crlf0710 opened this issue Apr 25, 2019 · 4 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@crlf0710
Copy link
Member

I wonder if it's feasible to ship llvm-rc.exe for windows targets. This tool has limited capacity compared with windres.exe from MinGW and rc.exe from MSVC, but i think it can make steps towards solving rust-lang/rfcs#721 or similar issues.

@Centril Centril added O-windows Operating system: Windows T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed O-windows Operating system: Windows labels Apr 25, 2019
@hellow554
Copy link
Contributor

hellow554 commented Apr 25, 2019

CC #49584

I think this could by done by adding it to llvm-tools-preview. What do you think about that @japaric? (ping to you, because you were the moving force for llvm-tools).

@jonas-schievink jonas-schievink added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 25, 2019
@cluck
Copy link

cluck commented Dec 14, 2019

Looks like this is solved?

C:\opt\LLVM-9.0.0\x86\bin>llvm-rc.exe --version
Exactly one input file should be provided.

@jonas-schievink
Copy link
Contributor

@cluck Aren't you running from the LLVM installation directory? Try checking what the llvm-tools-preview rustup component provides

@cluck
Copy link

cluck commented Dec 15, 2019

Oh, I see, this is about intentionally shipping the llvm binary with Rust, for when the LLVM package is not installed.

That's a different approach than for rc.exe and windres.exe, which continue to be external dependencies (Visual Studio or Windows SDK 10, and MSYS2/MingW/Cygwin/...).

@jonas-schievink jonas-schievink added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 15, 2019
@Nilstrieb Nilstrieb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants