-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Description
In f32::signum
and f64::signum
we use intrinsics::copysignf32
and intrinsics::copysignf64
. However, these intrinsics are exposed with a stable wrapper f32::copysign
and f64::copysign
. We should use those instead.
Line 191 in d132f54
unsafe { intrinsics::copysignf32(1.0, self) } |
Line 169 in d132f54
unsafe { intrinsics::copysignf64(1.0, self) } |
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.