Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cases under run-pass directory are not running #62775

Closed
BaoshanPang opened this issue Jul 18, 2019 · 2 comments · Fixed by #62797
Closed

test cases under run-pass directory are not running #62775

BaoshanPang opened this issue Jul 18, 2019 · 2 comments · Fixed by #62797
Assignees
@petrochenkov
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.

Comments

@BaoshanPang
Copy link
Contributor

With the change in function should_run_successfully() of commit 54337fa:
- RunPass => true,
- Ui => self.props.pass_mode == Some(PassMode::Run),
+ RunPass | Ui => self.effective_pass_mode() == Some(PassMode::Run),

The test cases under run-pass directory are tested for building only, the compiled test cases are not running any more.
Does it work as design?
@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. labels Jul 18, 2019
@petrochenkov petrochenkov self-assigned this Jul 18, 2019
@petrochenkov
Copy link
Contributor

Oh. This is bad.
Will fix today.
cc @Centril (on vacation)

@petrochenkov petrochenkov mentioned this issue Jul 19, 2019
Merged
@petrochenkov
Copy link
Contributor

Fixed in #62797.

bors added a commit that referenced this issue Jul 21, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
529828e 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
bors added a commit that referenced this issue Jul 21, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
787acc6 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
bors added a commit that referenced this issue Jul 21, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
25035ca 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
bors added a commit that referenced this issue Jul 22, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
4bc1ce7 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrochenkov petrochenkov

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Require run-pass tests without annotations to run successfully again petrochenkov/rust
3 participants
@jonas-schievink @BaoshanPang @petrochenkov