Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Require run-pass tests without annotations to run successfully again #62797

Merged
merged 2 commits into from
Jul 22, 2019
Merged

tests: Require run-pass tests without annotations to run successfully again #62797

merged 2 commits into from
Jul 22, 2019

Conversation

petrochenkov
Copy link
Contributor

Fixes #62775 (regression from #61755)

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2019
@petrochenkov petrochenkov mentioned this pull request Jul 19, 2019
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

r? @Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 19, 2019

📌 Commit e4c8ba97f6cc7470287951f151bc982d8ff8b76f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2019
@Mark-Simulacrum
Copy link
Member

@bors rollup=never

Presumably we may have introduced regressions since then.

@petrochenkov
Copy link
Contributor Author

One test regressed (cannot run a library).
I haven't run fulldeps tests though.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 19, 2019

📌 Commit 892cb9ab65f8b3189baba74343ab6c6de9d8a26a has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 19, 2019

⌛ Testing commit 892cb9ab65f8b3189baba74343ab6c6de9d8a26a with merge 1091349b3347baf11d536584ccee3af65c163d74...

@bors
Copy link
Contributor

bors commented Jul 19, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2019
@petrochenkov petrochenkov mentioned this pull request Jul 19, 2019
Closed
@petrochenkov
Copy link
Contributor Author

#62807 filed.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 19, 2019

📌 Commit e5939c36fcddf39425ae2c50c47285c1be044d9f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2019
@bors
Copy link
Contributor

bors commented Jul 19, 2019

⌛ Testing commit e5939c36fcddf39425ae2c50c47285c1be044d9f with merge 9481657ae517012b44df3a0bc7bc9f5b61d6deed...

@bors
Copy link
Contributor

bors commented Jul 19, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 19, 2019
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2019
@Centril
Copy link
Contributor

Centril commented Jul 21, 2019

@bors treeclosed=1500

Closing the tree until this is merged.

@Centril

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2019
@matthiaskrgr

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@matthiaskrgr

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Jul 21, 2019

@bors p=1501

@bors
Copy link
Contributor

bors commented Jul 21, 2019

⌛ Testing commit b5af947 with merge 25035ca...

bors added a commit that referenced this pull request Jul 21, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
25035ca 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
@bors
Copy link
Contributor

bors commented Jul 22, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

The job i686-msvc-2 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-07-22T01:41:41.0875518Z ---- [run-pass] run-pass\backtrace.rs stdout ----
2019-07-22T01:41:41.0875699Z 
2019-07-22T01:41:41.0875870Z error: test run failed!
2019-07-22T01:41:41.0876038Z status: exit code: 101
2019-07-22T01:41:41.0877289Z command: PATH="D:\a\1\s\build\i686-pc-windows-msvc\stage2\lib\rustlib\i686-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x86;C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86;C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64;D:\a\1\s\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\1\s\build\i686-pc-windows-msvc\stage0\bin;D:\a\1\s\ninja;C:\Python27amd64;D:\a\1\s\citools\msys64\mingw32\bin;D:\a\1\s\citools\msys64\usr\bin;C:\Program Files (x86)\Inno Setup 5;D:\a\1\s\sccache;C:\agents\2.154.3\externals\git\cmd;C:\hostedtoolcache\windows\Python\3.6.8\x64;C:\hostedtoolcache\windows\Python\3.6.8\x64\Scripts;C:\Program Files\Mercurial;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\Program Files\Boost\1.69.0;C:\Users\VssAdministrator\.dotnet\tools;C:\Program Files\dotnet;C:\mysql-5.7.21-winx64\bin;C:\Program Files\Java\zulu-8-azure-jdk_8.38.0.13-8.0.212-win_x64\bin;C:\npm\prefix;C:\Program Files\Rust\.cargo\bin;C:\hostedtoolcache\windows\Ruby\2.5.3\x64\bin;C:\Go1.12.4\bin;C:\Program Files\Git\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\hostedtoolcache\windows\Python\3.6.8\Scripts;C:\hostedtoolcache\windows\Python\3.6.8;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Program Files\Microsoft MPI\Bin;C:\windows\system32;C:\windows;C:\windows\System32\Wbem;C:\windows\System32\WindowsPowerShell\v1.0;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\6;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\tools\php;C:\Program Files (x86)\Subversion\bin;C:\Program Files\nodejs;C:\Program Files\CMake\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Program Files\OpenSSL\bin;C:\Users\VssAdministrator\AppData\Local\Microsoft\WindowsApps" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\test\\run-pass\\backtrace\\a.exe"
2019-07-22T01:41:41.0878698Z ------------------------------------------
2019-07-22T01:41:41.0878873Z 
2019-07-22T01:41:41.0879055Z ------------------------------------------
2019-07-22T01:41:41.0879208Z stderr:
2019-07-22T01:41:41.0879208Z stderr:
2019-07-22T01:41:41.0879368Z ------------------------------------------
2019-07-22T01:41:41.0879555Z thread 'main' panicked at 'bad output: thread 'main' panicked at 'explicit panic', D:\a\1\s\src/test\run-pass\backtrace.rs:16:9
2019-07-22T01:41:41.0880060Z    0: std::panicking::take_hook
2019-07-22T01:41:41.0880235Z    1: std::panicking::take_hook
2019-07-22T01:41:41.0880566Z    2: std::panicking::rust_panic_with_hook
2019-07-22T01:41:41.0880723Z ', D:\a\1\s\src/test\run-pass\backtrace.rs:66:5
---
2019-07-22T01:41:41.0884491Z thread 'main' panicked at 'Some tests failed', src\tools\compiletest\src\main.rs:535:22
2019-07-22T01:41:41.0884703Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-22T01:41:41.0909482Z 
2019-07-22T01:41:41.0909692Z 
2019-07-22T01:41:41.0910883Z command did not execute successfully: "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\stage2\\bin" "--run-lib-path" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\stage2\\lib\\rustlib\\i686-pc-windows-msvc\\lib" "--rustc-path" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "--src-base" "D:\\a\\1\\s\\src/test\\run-pass" "--build-base" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\test\\run-pass" "--stage-id" "stage2-i686-pc-windows-msvc" "--mode" "run-pass" "--target" "i686-pc-windows-msvc" "--host" "i686-pc-windows-msvc" "--llvm-filecheck" "D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=D:\\a\\1\\s\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "--docck-python" "C:\\Python27amd64\\python2.7" "--lldb-python" "C:\\Python27amd64\\python2.7" "--gdb" "D:\\a\\1\\s\\citools\\msys64\\mingw32\\bin\\gdb" "--llvm-version" "9.0.0-rust-1.38.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-22T01:41:41.0912189Z 
2019-07-22T01:41:41.0912232Z 
2019-07-22T01:41:41.1835455Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test src/test/ui src/test/run-pass src/test/compile-fail src/test/run-pass-fulldeps src/tools/linkchecker
2019-07-22T01:41:41.1835702Z Build completed unsuccessfully in 2:39:54
2019-07-22T01:41:41.1835702Z Build completed unsuccessfully in 2:39:54
2019-07-22T01:41:41.2124054Z make: *** [Makefile:86: ci-subset-2] Error 1
2019-07-22T01:41:41.6115831Z ##[error]Bash exited with code '2'.
2019-07-22T01:41:41.6928185Z ##[section]Starting: Upload CPU usage statistics
2019-07-22T01:41:41.7911440Z ==============================================================================
2019-07-22T01:41:41.7911540Z Task         : Bash
2019-07-22T01:41:41.7911629Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2019
@petrochenkov
Copy link
Contributor Author

One more test added to #62844.
@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 22, 2019

📌 Commit 39d144e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019
@pietroalbini
Copy link
Member

@bors treeclosed=1500

@bors
Copy link
Contributor

bors commented Jul 22, 2019

⌛ Testing commit 39d144e with merge 4bc1ce7...

bors added a commit that referenced this pull request Jul 22, 2019
@bors
Auto merge of #62797 - petrochenkov:run-pass-hole, r=Mark-Simulacrum
4bc1ce7 
tests: Require run-pass tests without annotations to run successfully again

Fixes #62775 (regression from #61755)
@bors
Copy link
Contributor

bors commented Jul 22, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 4bc1ce7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2019
@bors bors merged commit 39d144e into rust-lang:master Jul 22, 2019
@petrochenkov
Copy link
Contributor Author

@bors treeclosed-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test cases under run-pass directory are not running
8 participants
@petrochenkov @rust-highfive @Mark-Simulacrum @bors @Centril @matthiaskrgr @pietroalbini @alexcrichton