Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy-driver no longer builds after rust-lang/rust#64864 #64867

Closed
rust-highfive opened this issue Sep 28, 2019 · 3 comments
Closed

clippy-driver no longer builds after rust-lang/rust#64864 #64867

rust-highfive opened this issue Sep 28, 2019 · 3 comments
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #64864, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2019
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Sep 28, 2019
bors added a commit to rust-lang/rust-clippy that referenced this issue Sep 28, 2019
bors added a commit to rust-lang/rust-clippy that referenced this issue Sep 28, 2019
@tesuji tesuji mentioned this issue Sep 29, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Oct 3, 2019

triage: P-medium, removing nomination label. I am not thrilled that highfive is assigning seven people to the bug.

@Manishearth can we narrow the assignment down to a smaller set of people who will assume responsibility (and that I could follow-up with in the future if necessary?)

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Oct 3, 2019
@flip1995
Copy link
Member

flip1995 commented Oct 3, 2019

This issue can be closed, since Clippy toolstate is currently test-pass (fixed in #64963) https://rust-lang-nursery.github.io/rust-toolstate/

can we narrow the assignment down to a smaller set of people

Maybe we could add a list of "fixers", which are not necessarily maintainers, to the script:

# List of people to ping when the status of a tool or a book changed.
# These should be collaborators of the rust-lang/rust repository (with at least
# read privileges on it). CI will fail otherwise.
MAINTAINERS = {

"fixers" are then people who regularly do rustups in Clippy/tools (if they want to be added)

@Centril Centril closed this as completed Oct 3, 2019
@Manishearth
Copy link
Member

@pnkfelix I'm not sure I understand why the compiler team would ever need to follow up on these. Perhaps these autocreated issues should also be autotriaged?

Either way, you can consider @oli-obk and me as the people to contact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants