Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc uses fake italics for code #65502

Closed
tspiteri opened this issue Oct 17, 2019 · 2 comments · Fixed by #65665 or #80705
Closed

Rustdoc uses fake italics for code #65502

tspiteri opened this issue Oct 17, 2019 · 2 comments · Fixed by #65665 or #80705
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tspiteri
Copy link
Contributor

For example https://doc.rust-lang.org/std/primitive.i32.html has the string “See also the std::i32 module” which inludes code in italics. This is rendered using fake italics because the Source Code Pro italic font is not included.

Adding the italic font would fix this, but at the cost of having an extra font to download. Is the better formatting worth the (one-time?) download?

If there is an interest, I can prepare a PR to include the latest version of Source Code Pro including the italic font. The sizes are as follows:

Font Current Size Latest Size
Regular 55472 95872
Semibold 55360 95576
Italic 84264
Total 110832 275712
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 17, 2019
@tspiteri tspiteri mentioned this issue Oct 21, 2019
Merged
@bors bors closed this as completed in 423137b Nov 20, 2019
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 21, 2019 •
edited
Loading

Reopening since it's not fixed.

@tspiteri

This comment has been minimized.

Sign in to view
@tspiteri tspiteri mentioned this issue Jan 4, 2021
Merged
@bors bors closed this as completed in 0e96c62 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
3 participants
@jonas-schievink @GuillaumeGomez @tspiteri