Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary value dropped while borrowed #67609

Closed
Mark-Simulacrum opened this issue Dec 25, 2019 · 6 comments · Fixed by #67621
Closed

temporary value dropped while borrowed #67609

Mark-Simulacrum opened this issue Dec 25, 2019 · 6 comments · Fixed by #67621
Assignees
Labels
A-borrow-checker Area: The borrow checker C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

root: imperative - 3 (1 gh, 2 crates.io) detected crates which regressed due to this

cc @matthewjasper (likely MIR borrowck related, though not the transition itself as that happened last cycle)

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 25, 2019
@Centril

This comment has been minimized.

@matthewjasper
Copy link
Contributor

This is a change in promotion. cc @ecstatic-morse

@matthewjasper
Copy link
Contributor

matthewjasper commented Dec 25, 2019

Minimized:

static DIVISIONS_200312: Option<String> = None;

pub static DIVISIONS: &&Option<String> = {
    let x = &&DIVISIONS_200312;
    x
};

@matthewjasper
Copy link
Contributor

Maybe #66587?

@matthewjasper
Copy link
Contributor

matthewjasper commented Dec 25, 2019

or #66642.
edit: Bisection suggests that its this.
No, it's neither of these.

@matthewjasper
Copy link
Contributor

It's #66950, likely #66654.

@matthewjasper matthewjasper self-assigned this Dec 25, 2019
@jonas-schievink jonas-schievink added A-borrow-checker Area: The borrow checker C-bug Category: This is a bug. labels Dec 25, 2019
@bors bors closed this as completed in b88ce0e Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-borrow-checker Area: The borrow checker C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants