Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#69851 #69855

Closed
rust-highfive opened this issue Mar 9, 2020 · 3 comments · Fixed by #69961
Closed

miri no longer builds after rust-lang/rust#69851 #69855

rust-highfive opened this issue Mar 9, 2020 · 3 comments · Fixed by #69961
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69851, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2020
@RalfJung
Copy link
Member

Already fixed in Miri, but I have some PRs open that will break Miri again so I am waiting a bit before updating the submodule.

@spastorino spastorino added P-medium Medium priority and removed I-nominated labels Mar 11, 2020
@spastorino
Copy link
Member

Tagging as P-medium check Zulip discussion here

@RalfJung RalfJung mentioned this issue Mar 12, 2020
Merged
@RalfJung
Copy link
Member

Blocked on #69999

@bors bors closed this as completed in 5da2e53 Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update miri RalfJung/rust
5 participants
@spastorino @eddyb @RalfJung @oli-obk @rust-highfive