Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for wasi_ext #71213

Open
2 tasks
coolreader18 opened this issue Apr 16, 2020 · 4 comments
Open
2 tasks

Tracking Issue for wasi_ext #71213

coolreader18 opened this issue Apr 16, 2020 · 4 comments
Labels
B-unstable Feature: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@coolreader18
Copy link
Contributor

The feature gate for the issue is #![feature(wasi_ext)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

When should this be stabilized? Is wasi as a specification stable enough for wasi-specific APIs to be included in std?

Implementation history

#59619

@coolreader18 coolreader18 added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Apr 16, 2020
@jonas-schievink jonas-schievink added B-unstable Feature: Implemented in the nightly compiler and unstable. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 16, 2020
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 29, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jul 15, 2021
… r=dtolnay

Add tracking issue number to `wasi_ext`

Feature `wasi_ext` is tracked by rust-lang#71213 but is was not in the source code.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jul 15, 2021
… r=dtolnay

Add tracking issue number to `wasi_ext`

Feature `wasi_ext` is tracked by rust-lang#71213 but is was not in the source code.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jul 15, 2021
… r=dtolnay

Add tracking issue number to `wasi_ext`

Feature `wasi_ext` is tracked by rust-lang#71213 but is was not in the source code.
seanyoung added a commit to seanyoung/inkwell that referenced this issue Sep 24, 2021
`cargo build --target wasm32-wasi --features llvm11-0` fails with:

   --> /home/sean/git/inkwell/src/module.rs:601:95
    |
601 |     pub fn write_bitcode_to_file(&self, file: &File, should_close: bool, unbuffered: bool) -> bool {
    |            ---------------------                                                              ^^^^ expected `bool`, found `()`
    |            |
    |            implicitly returns `()` as its body has no tail or `return` expression

Note that as_raw_fd() cannot be used on wasi yet, since this depends on
wasm_ext which is unstable:

rust-lang/rust#71213

Signed-off-by: Sean Young <sean@mess.org>
@bstrie
Copy link
Contributor

bstrie commented Apr 7, 2022

Does anyone know what the status of this feature is?

@a1phyr
Copy link
Contributor

a1phyr commented Apr 13, 2022

I don't think we want to stabilize this feature while WASI is not stable itself.

@alyssais

This comment was marked as off-topic.

smoothwork94131 added a commit to smoothwork94131/inkwell that referenced this issue Oct 8, 2023
`cargo build --target wasm32-wasi --features llvm11-0` fails with:

   --> /home/sean/git/inkwell/src/module.rs:601:95
    |
601 |     pub fn write_bitcode_to_file(&self, file: &File, should_close: bool, unbuffered: bool) -> bool {
    |            ---------------------                                                              ^^^^ expected `bool`, found `()`
    |            |
    |            implicitly returns `()` as its body has no tail or `return` expression

Note that as_raw_fd() cannot be used on wasi yet, since this depends on
wasm_ext which is unstable:

rust-lang/rust#71213

Signed-off-by: Sean Young <sean@mess.org>
@banocean
Copy link

I don't think we want to stabilize this feature while WASI is not stable itself.

Are we talking about WASI 1.0 or including following APIs in WASI specification (which just happened as part of WASI Preview 2)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-unstable Feature: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants