Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Intra doc links from Deref/etc do not link to the same page #74458

Open
jyn514 opened this issue Jul 17, 2020 · 1 comment
Open

rustdoc: Intra doc links from Deref/etc do not link to the same page #74458

jyn514 opened this issue Jul 17, 2020 · 1 comment
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jul 17, 2020

A slight degradation in quality [from manual links] is that the #method.foo links would previously link to the same page on String's documentation, and now they will navigate to str.

Originally posted by @Manishearth in #74453.
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Jul 17, 2020
@jyn514 jyn514 mentioned this issue Jul 17, 2020
Merged
@Manishearth
Copy link
Member

More in general, if the thing being linked to exists on the same page, we should link to it on the same page.

@Manishearth Manishearth changed the title rustdoc: No way to make an intra-doc link to an inlined Deref method rustdoc: Intra doc links from Deref/etc do not link to the same page Jul 17, 2020
@Manishearth Manishearth mentioned this issue Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Manishearth @jyn514