missing-tools broken when tools are explicitly selected

With config.toml setup like

[build]
tools=["analysis","cargo","clippy","rls","rustfmt"]
[dist]
missing-tools=true

installing of all tools is still attempted even after one of them breaks (exemplified below with the RLS failure on nightly 2020-07-18). Since we specified that missing tools are ok the install should not be attempted at all.

   Compiling rustc-ap-rustc_ast v664.0.0
     Running `/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/bootstrap/debug/rustc --crate-name rustc_ap_rustc_ast --edition=2018 /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/vendor/rustc-ap-rustc_ast/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -Cembed-bitcode=no -C debuginfo=0 -C metadata=c07ae9971b925141 -C extra-filename=-c07ae9971b925141 --out-dir /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps --target i686-unknown-freebsd -C linker=cc -L dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps -L dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/release/deps --extern bitflags=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-night
 ly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libbitflags-117f14f53e7afb2e.rmeta --extern log=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/liblog-7a5637c5512dd57e.rmeta --extern rustc_data_structures=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_data_structures-217cd924ea1407d2.rmeta --extern rustc_index=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_index-6b13b73ebc7cde5e.rmeta --extern rustc_lexer=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_lexer-d6f8c1c4847ba92e.rmeta --extern rustc_macros=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-
 src/build/i686-unknown-freebsd/stage2-tools/!
 release/deps/librustc_ap_rustc_macros-377e4919d115575b.so --extern rustc_serialize=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_serialize-5cbf06ed31378d81.rmeta --extern rustc_span=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_span-405f1cc4da7809cd.rmeta --extern scoped_tls=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libscoped_tls-fac9e65d4a46bba0.rmeta --extern smallvec=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libsmallvec-be597a8c8a447051.rmeta --cap-lints allow -Zmacro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Zbinary-dep-depinfo -L native=/wrkdirs/usr/ports/lang/rust-nightly/work/ru
 stc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/build/psm-801b7322fb2af3c1/out`
rustc command: "LD_LIBRARY_PATH"="/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2/lib:/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/release/deps:/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2/lib" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2/bin/rustc" "--crate-name" "rustc_ap_rustc_ast" "--edition=2018" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/vendor/rustc-ap-rustc_ast/lib.rs" "--error-format=json" "--json=diagnostic-rendered-ansi,artifacts" "--crate-type" "lib" "--emit=dep-info,metadata,link" "-C" "opt-level=3" "-Cembed-bitcode=no" "-C" "debuginfo=0" "-C" "metadata=c07ae9971b925141" "-C" "extra-filename=-c07ae9971b925141" "--out-dir" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps" "
 --target" "i686-unknown-freebsd" "-C" "linker=cc" "-L" "dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps" "-L" "dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/release/deps" "--extern" "bitflags=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libbitflags-117f14f53e7afb2e.rmeta" "--extern" "log=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/liblog-7a5637c5512dd57e.rmeta" "--extern" "rustc_data_structures=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_data_structures-217cd924ea1407d2.rmeta" "--extern" "rustc_index=/wrkdirs/usr/ports/lang/rust-nightly/work/
 rustc-nightly-src/build/i686-unknown-freebsd!
 /stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_index-6b13b73ebc7cde5e.rmeta" "--extern" "rustc_lexer=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_lexer-d6f8c1c4847ba92e.rmeta" "--extern" "rustc_macros=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/release/deps/librustc_ap_rustc_macros-377e4919d115575b.so" "--extern" "rustc_serialize=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_serialize-5cbf06ed31378d81.rmeta" "--extern" "rustc_span=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_span-405f1cc4da7809cd.rmeta" "--extern" "scoped_tls=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686
 -unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libscoped_tls-fac9e65d4a46bba0.rmeta" "--extern" "smallvec=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libsmallvec-be597a8c8a447051.rmeta" "--cap-lints" "allow" "-Zmacro-backtrace" "-Clink-args=-Wl,-rpath,$ORIGIN/../lib" "-Zbinary-dep-depinfo" "-L" "native=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/build/psm-801b7322fb2af3c1/out" "--sysroot" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2"
sysroot: "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2"
libdir: "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2/lib"
error[E0635]: unknown feature `const_transmute`
  --> /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/vendor/rustc-ap-rustc_ast/lib.rs:13:12
   |
13 | #![feature(const_transmute)]
   |            ^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0635`.
error: could not compile `rustc-ap-rustc_ast`.

Caused by:
  process didn't exit successfully: `/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/bootstrap/debug/rustc --crate-name rustc_ap_rustc_ast --edition=2018 /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/vendor/rustc-ap-rustc_ast/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -Cembed-bitcode=no -C debuginfo=0 -C metadata=c07ae9971b925141 -C extra-filename=-c07ae9971b925141 --out-dir /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps --target i686-unknown-freebsd -C linker=cc -L dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps -L dependency=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/release/deps --extern bitflags=/wrkdirs/usr/ports/lang/rust-n
 ightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libbitflags-117f14f53e7afb2e.rmeta --extern log=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/liblog-7a5637c5512dd57e.rmeta --extern rustc_data_structures=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_data_structures-217cd924ea1407d2.rmeta --extern rustc_index=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_index-6b13b73ebc7cde5e.rmeta --extern rustc_lexer=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_lexer-d6f8c1c4847ba92e.rmeta --extern rustc_macros=/wrkdirs/usr/ports/lang/rust-nigh
 tly/work/rustc-nightly-src/build/i686-unknow!
 n-freebsd/stage2-tools/release/deps/librustc_ap_rustc_macros-377e4919d115575b.so --extern rustc_serialize=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_serialize-5cbf06ed31378d81.rmeta --extern rustc_span=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/librustc_ap_rustc_span-405f1cc4da7809cd.rmeta --extern scoped_tls=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libscoped_tls-fac9e65d4a46bba0.rmeta --extern smallvec=/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/deps/libsmallvec-be597a8c8a447051.rmeta --cap-lints allow -Zmacro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Zbinary-dep-depinfo -L native=/wrkdirs/usr/ports/la
 ng/rust-nightly/work/rustc-nightly-src/build/i686-unknown-freebsd/stage2-tools/i686-unknown-freebsd/release/build/psm-801b7322fb2af3c1/out` (exit code: 1)
command did not execute successfully: "/wrkdirs/usr/ports/lang/rust-nightly/work/bootstrap/bin/cargo" "build" "--target" "i686-unknown-freebsd" "-Zbinary-dep-depinfo" "-j" "1" "-v" "--release" "--frozen" "--manifest-path" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/src/tools/rls/Cargo.toml" "--features" "clippy" "--message-format" "json-render-diagnostics"
expected success, got: exit code: 101
      < ToolBuild { compiler: Compiler { stage: 2, host: "i686-unknown-freebsd" }, target: "i686-unknown-freebsd", tool: "rls", path: "src/tools/rls", mode: ToolRustc, is_optional_tool: true, source_type: Submodule, extra_features: ["clippy"] }
    < Rls { compiler: Compiler { stage: 2, host: "i686-unknown-freebsd" }, target: "i686-unknown-freebsd", extra_features: [] }
Unable to build RLS, skipping dist
  < Rls { compiler: Compiler { stage: 2, host: "i686-unknown-freebsd" }, target: "i686-unknown-freebsd" }
Install rls stage2 (Some("i686-unknown-freebsd"))
running: "sh" "/wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/tmp/dist/rls-nightly-i686-unknown-freebsd/install.sh" "--prefix=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local" "--sysconfdir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/etc" "--datadir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/share" "--docdir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/share/doc/rust" "--bindir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/bin" "--libdir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/lib" "--mandir=/wrkdirs/usr/ports/lang/rust-nightly/work/stage/usr/local/share/man" "--disable-ldconfig"
sh: cannot open /wrkdirs/usr/ports/lang/rust-nightly/work/rustc-nightly-src/build/tmp/dist/rls-nightly-i686-unknown-freebsd/install.sh: No such file or directory

Full log (IPv6 only): http://beefy5.nyi.freebsd.org/data/121i386-default/542539/logs/rust-nightly-1.47.0.20200718.log

[dheatovwil]

Problem exists when using rustc-ap-rustc_ast v670.0.0 as well.

error: `std::intrinsics::transmute` is not yet stable as a const fn
   --> /home/tiong/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_ast-670.0.0/ptr.rs:136:17
    |
136 |                 std::mem::transmute(NonNull::<[T; 0]>::dangling() as NonNull<[T]>)
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add `#![feature(const_transmute)]` to the crate attributes to enable

I am sorry but the specific compiler error is orthogonal to the bug reported here. Please do not zoom in on it. It is about how x.py install is broken where even though RLS (probably same with any other tool) did not build (Unable to build RLS, skipping dist) and even though we have missing-tools=true in config.toml, the installation of it is still attempted when it should be skipped.

[dheatovwil]

Oh no. That's totally my bad, I was skimming through them way too quickly. Yes it doesn't belong here, I have hidden the comment.

[Enselic]

Triage: I would like to ask the reporter if this can still be reproduced. But the account is deleted, so let's close.