Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py check checks bootstrap itself #76624

Closed
jyn514 opened this issue Sep 12, 2020 · 1 comment · Fixed by #84781
Closed

x.py check checks bootstrap itself #76624

jyn514 opened this issue Sep 12, 2020 · 1 comment · Fixed by #84781
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 12, 2020

If bootstrap is running, it must compile successfully. So there's no point in checking it again.
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Sep 12, 2020
@Mark-Simulacrum
Copy link
Member

That is not quite true - this checks tests as well. It's maybe not too useful, I would be fine with turning it off by default.

@jyn514 jyn514 added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Sep 13, 2020
@jyn514 jyn514 mentioned this issue May 1, 2021
Merged
@bors bors closed this as completed in 1224e13 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't check bootstrap artifacts by default jyn514/rust
2 participants
@Mark-Simulacrum @jyn514