Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#79336 #79406

Closed
rust-highfive opened this issue Nov 25, 2020 · 3 comments · Fixed by #79737
Closed

rls no longer builds after rust-lang/rust#79336 #79406

rust-highfive opened this issue Nov 25, 2020 · 3 comments · Fixed by #79737
Assignees
Labels
A-rls Area: Rust Language Server (RLS) C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #79336, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @camelid, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-rls Area: Rust Language Server (RLS) C-bug Category: This is a bug. labels Nov 25, 2020
@camelid camelid assigned camelid and unassigned Xanewok Nov 25, 2020
@camelid
Copy link
Member

camelid commented Nov 25, 2020

Huh, how did this PR break rls? ripgrep doesn't show any use of optin_builtin_traits, and it compiled fine locally.

Do I need to wait until there's a nightly with the changes or something?

@Mark-Simulacrum
Copy link
Member

RLS uses the rustc-ap-rustc_data_structures-686.0.0 crate which contains the optin_builtin_traits.

@camelid
Copy link
Member

camelid commented Nov 25, 2020

I think this might be a little too beyond my understanding of how to fix for now, so I'm unassigning myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rls Area: Rust Language Server (RLS) C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants