Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove everybody_loops? #82618

Closed
camelid opened this issue Feb 28, 2021 · 3 comments
Closed

Remove everybody_loops? #82618

camelid opened this issue Feb 28, 2021 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-discussion Category: Discussion or questions that doesn't represent real issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Feb 28, 2021 •
edited
Loading

Based on a quick ripgrep, everybody_loops seems to only be used for the -Z unpretty=everybody_loops CLI option. (#73566 removed rustdoc's use of everybody_loops.)

Does anyone use -Z unpretty=everybody_loops? If not, I think we should remove the pass.

cc #82617
cc @jyn514
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-discussion Category: Discussion or questions that doesn't represent real issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2021
@camelid
Copy link
Member Author

camelid commented Feb 28, 2021

Not sure if this requires an MCP, but thought I'd start with an issue.

@camelid
Copy link
Member Author

camelid commented Feb 28, 2021 •
edited
Loading

It looks like this has been discussed before: #73566 (comment)

If we can't remove it because people still use it, maybe it's worth adding documentation to #82617 saying that it's only there for the flag and you shouldn't use it in compiler/rustdoc/etc code?

@jyn514
Copy link
Member

jyn514 commented Feb 28, 2021

Closing this since at least @pnkfelix still uses the option.

@jyn514 jyn514 closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-discussion Category: Discussion or questions that doesn't represent real issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyn514 @camelid