Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub on macro_rules! not supported in rustfmt #82640

Closed
JulianKnodt opened this issue Feb 28, 2021 · 3 comments
Closed

pub on macro_rules! not supported in rustfmt #82640

JulianKnodt opened this issue Feb 28, 2021 · 3 comments
Labels
C-bug Category: This is a bug.

Comments

@JulianKnodt
Copy link
Contributor

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=71be237d1aed61df9bbdb665bbd5a056`

I expected to be able to format it with rustfmt,

but when running rustfmt there is an error despite compilation succeeding.

The implementation PR is #82296, but unsure if there's a RFC for the original idea.

@JulianKnodt JulianKnodt added the C-bug Category: This is a bug. label Feb 28, 2021
@JulianKnodt JulianKnodt changed the title pub on macro rules not supported in rustfmt pub on macro_rules! not supported in rustfmt Feb 28, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 28, 2021

@JulianKnodt this should be reported to https://github.com/rust-lang/rustfmt.

@jyn514
Copy link
Member

jyn514 commented Feb 28, 2021

Also, this is probably just waiting on a submodule update.

@JulianKnodt
Copy link
Contributor Author

my b, didn't realize that rustfmt wasn't in the compiler repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants