Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc should report unknown doc(...) attributes #82652

Closed
jyn514 opened this issue Mar 1, 2021 · 1 comment · Fixed by #82662
Closed

Rustdoc should report unknown doc(...) attributes #82652

jyn514 opened this issue Mar 1, 2021 · 1 comment · Fixed by #82662
Assignees
@GuillaumeGomez
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 1, 2021

I tried this code:

#![doc(xxx)]

I expected to see this happen: Rustdoc warns that xxx is an unknown doc attribute.
Instead, this happened: Rustdoc silently ignores the attribute.

Meta

rustdoc --version: rustdoc 1.52.0-nightly (0148b97 2021-02-18)

Found while working on #82651.
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. labels Mar 1, 2021
@GuillaumeGomez
Copy link
Member

Oh funny! Gonna fix it then. :)

@GuillaumeGomez GuillaumeGomez self-assigned this Mar 1, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 1, 2021
Merged
@bors bors closed this as completed in 0c6b69a Mar 2, 2021
@giraffate giraffate mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn about unknown doc attributes GuillaumeGomez/rust
2 participants
@GuillaumeGomez @jyn514