Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HorizonOS regression in FileTimes #100249

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix HorizonOS regression in FileTimes #100249

merged 1 commit into from
Aug 15, 2022

Conversation

Meziu
Copy link
Contributor

@Meziu Meziu commented Aug 7, 2022

The changes in #98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround.

@AzureMarker @ian-h-chamberlain
r? @nagisa

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2022
@joshtriplett
Copy link
Member

Does Horizon support any fallback, such as futimes?

@bors r+

@bors
Copy link
Contributor

bors commented Aug 8, 2022

📌 Commit 926f587 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2022
Fix HorizonOS regression in FileTimes

The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of  targets which require a workaround.

`@AzureMarker` `@ian-h-chamberlain`
r? `@nagisa`
@ian-h-chamberlain
Copy link
Contributor

ian-h-chamberlain commented Aug 8, 2022

Does Horizon support any fallback, such as futimes?

@joshtriplett from a quick look, it seems like there is one in its version of newlib, but the libc crate doesn't a declaration for it, so std can't use it without a libc PR.

Is there a codepath in library/std/src/sys/unix/fs.rs that uses the fallback futimes? It shouldn't be much work to upstream a libc PR to expose the futimes call.

Edit: nevermind, I tried it with the C toolchain and got an undefined reference, so I don't think this is an option. The homebrew filesystem on the 3DS is a bit unusual, so I suppose it's not too surprising.

@Meziu
Copy link
Contributor Author

Meziu commented Aug 9, 2022

Edit: nevermind, I tried it with the C toolchain and got an undefined reference, so I don't think this is an option. The homebrew filesystem on the 3DS is a bit unusual, so I suppose it's not too surprising.

Yeah I had checked for it before making the PR and found it unavailable. I’m sorry for not being active 😓

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 14, 2022
Fix HorizonOS regression in FileTimes

The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of  targets which require a workaround.

`@AzureMarker` `@ian-h-chamberlain`
r? `@nagisa`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#100249 (Fix HorizonOS regression in FileTimes)
 - rust-lang#100253 (Recover from mutable variable declaration where `mut` is placed before `let`)
 - rust-lang#100482 (Add Duration rounding change to release note)
 - rust-lang#100523 ([rustdoc] remove Clean trait)
 - rust-lang#100524 (Impl `Debug` for some structs of rustbuild)
 - rust-lang#100526 (Add tests for the drop behavior of some control flow constructs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b8b3ead into rust-lang:master Aug 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants