Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Resugar async fn return type in clean, not html #101204

Merged
merged 1 commit into from
Aug 31, 2022
Merged

rustdoc: Resugar async fn return type in clean, not html #101204

merged 1 commit into from
Aug 31, 2022

Conversation

aDotInTheVoid
Copy link
Member

This way it also happens for json output.

Fixes #101199

r? @GuillaumeGomez

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 30, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2022
@GuillaumeGomez
Copy link
Member

Looks great, thanks! I think it'll even improve performance. Let's check.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 30, 2022
@bors
Copy link
Contributor

bors commented Aug 30, 2022

⌛ Trying commit c4f6f12d7effe3027460943c7851e16194209406 with merge 00721cc66e974555656d1174b5f6269fedae9db3...

@bors
Copy link
Contributor

bors commented Aug 30, 2022

☀️ Try build successful - checks-actions
Build commit: 00721cc66e974555656d1174b5f6269fedae9db3 (00721cc66e974555656d1174b5f6269fedae9db3)

@rust-timer
Copy link
Collaborator

Queued 00721cc66e974555656d1174b5f6269fedae9db3 with parent 0631ea5, future comparison URL.

@aDotInTheVoid
rustdoc: Resugar async fn return type in clean, not html
6099d17 
This way it also happens for json output.

Fixes rust-lang#101199
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (00721cc66e974555656d1174b5f6269fedae9db3): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 6.2% [6.2%, 6.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-3.5%, -2.0%] 2
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 30, 2022
@GuillaumeGomez
Copy link
Member

Small improvement in the performance as I thought, well done!

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 30, 2022

📌 Commit 6099d17 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 31, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101204 - aDotInTheVoid:async-resugar-in-cle…
72e33a3 
…an, r=GuillaumeGomez

rustdoc: Resugar async fn return type in `clean`, not `html`

This way it also happens for json output.

Fixes rust-lang#101199

r? `@GuillaumeGomez`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 31, 2022
Closed
@RalfJung RalfJung mentioned this pull request Aug 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2022
@bors
Auto merge of rust-lang#101238 - RalfJung:rollup-bzcmobj, r=RalfJung
4fd4de7 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#90946 (Ignore `reference`s in "Type::inner_def_id")
 - rust-lang#100730 (Migrate rustc_monomorphize to use SessionDiagnostic)
 - rust-lang#100753 (translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1)
 - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)
 - rust-lang#101204 (rustdoc: Resugar async fn return type in `clean`, not `html`)
 - rust-lang#101216 (Use in-page links for sanitizer docs.)
 - rust-lang#101237 (fix into_iter on ZST)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ed9ac6 into rust-lang:master Aug 31, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 31, 2022
@Enselic Enselic mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynecx cynecx cynecx left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Rustdoc-Json: async fn foo() -> T return type is given as impl Future<Output=T> not T
7 participants
@aDotInTheVoid @GuillaumeGomez @rust-timer @bors @cynecx @rust-highfive @rustbot