Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code generation of Rvalue::Repeat with 128 bit values #101612

Merged
merged 2 commits into from Sep 10, 2022
Merged

Fix code generation of Rvalue::Repeat with 128 bit values #101612

merged 2 commits into from Sep 10, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 9, 2022

Closes #101585.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 9, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2022
@lcnr
Copy link
Contributor

lcnr commented Sep 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit e4d3abf has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2022
@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 9, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2022
@bors
Auto merge of rust-lang#101617 - Dylan-DPC:rollup-iiy4ipc, r=Dylan-DPC
395e56f 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#101366 (Restore old behaviour on broken UNC paths)
 - rust-lang#101492 (Suggest adding array lengths to references to arrays if possible)
 - rust-lang#101529 (Fix the example code and doctest for Formatter::sign_plus)
 - rust-lang#101573 (update `ParamKindOrd`)
 - rust-lang#101612 (Fix code generation of `Rvalue::Repeat` with 128 bit values)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07a9c10 into rust-lang:master Sep 10, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 10, 2022
@apiraino
Copy link
Contributor

Beta backport declined as per compiler team on Zulip, since we are so close to the next release. Let this land in the next stable.

@rustbot label -beta-nominated

@rustbot rustbot removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 15, 2022
@tmiasko tmiasko deleted the repeat128 branch November 28, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Returning [i128::MIN; 1] from a function actually returns [0i128; 1]
7 participants
@tmiasko @rust-highfive @lcnr @bors @apiraino @compiler-errors @rustbot