Skip to content

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Sep 11, 2022

Revives #95137. It's a pity that the original pr didn't land because the implementation is almost complete! All credits goes to @canndrew, and i just resolved the merge conflicts and updated the feature gate version number.

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
@crlf0710
Copy link
Member Author

cc #95360

@crlf0710 crlf0710 added A-coroutines Area: Coroutines F-coroutine_clone `#![feature(coroutine_clone)]` labels Sep 11, 2022
@rust-log-analyzer

This comment was marked as outdated.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 11, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2022

📌 Commit 4e9bcb5 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2022
@bors
Copy link
Collaborator

bors commented Sep 11, 2022

⌛ Testing commit 4e9bcb5 with merge 6f0c4a6...

@bors
Copy link
Collaborator

bors commented Sep 11, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6f0c4a6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2022
@bors bors merged commit 6f0c4a6 into rust-lang:master Sep 11, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 11, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6f0c4a6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [0.9%, 2.2%] 4
Improvements ✅
(primary)
-3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)
-1.1% [-1.2%, -0.8%] 4
All ❌✅ (primary) -3.4% [-3.4%, -3.4%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-6.9% [-6.9%, -6.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -6.9% [-6.9%, -6.9%] 1

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@canndrew
Copy link
Contributor

Ah, thanks tons @crlf0710 for picking this back up. I've been hella busy lately and let if fall by the wayside. Glad to see it made it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-coroutines Area: Coroutines F-coroutine_clone `#![feature(coroutine_clone)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants