Skip to content

Conversation

pietroalbini
Copy link
Member

Part of the release process.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2022
@pietroalbini
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Sep 16, 2022

📌 Commit 0e87dac has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
@Dylan-DPC
Copy link
Member

@bors p=1

@bors
Copy link
Collaborator

bors commented Sep 17, 2022

⌛ Testing commit 0e87dac with merge 5e09ca0523516846267bc1b2615dabe9d081a2ed...

@bors
Copy link
Collaborator

bors commented Sep 17, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (70/72)
..         (72/72)


/checkout/src/test/rustdoc-gui/basic-code.goml basic-code... FAILED
[ERROR] (line 3) expected 1 elements, found 0: for command `assert-count: (".line-numbers", 1)`
Build completed unsuccessfully in 0:01:59

@Mark-Simulacrum
Copy link
Member

@bors retry rustdoc-gui expected 1 elements, found 0: for command assert-count: (".line-numbers", 1)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2022
@bors
Copy link
Collaborator

bors commented Sep 17, 2022

⌛ Testing commit 0e87dac with merge c773c13...

@bors
Copy link
Collaborator

bors commented Sep 17, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing c773c13 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2022
@bors bors merged commit c773c13 into master Sep 17, 2022
@bors bors deleted the pa-bump-version branch September 17, 2022 19:34
@rustbot rustbot added this to the 1.66.0 milestone Sep 17, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c773c13): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
2.4% [2.1%, 2.7%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [2.1%, 2.7%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.0% [-5.2%, -4.7%] 2
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants