Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added which number is computed in compute_float. #102131

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Added which number is computed in compute_float. #102131

merged 1 commit into from
Sep 22, 2022

Conversation

orlp
Copy link
Contributor

@orlp orlp commented Sep 22, 2022

The original comment was very elaborate but ultimately did not mention at all what is being computed using parameters w, q, only referencing an external article for the algorithm.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 22, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2022
@thomcc
Copy link
Member

thomcc commented Sep 22, 2022

Yep, this matches the text of the source article (algorithm 1 on page 8 of https://arxiv.org/pdf/2101.11408.pdf).

r? @thomcc @bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 186debc has been approved by thomcc

It is now in the queue for this repository.

@rust-highfive rust-highfive assigned thomcc and unassigned joshtriplett Sep 22, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2022
@bors
Auto merge of rust-lang#102139 - Dylan-DPC:rollup-ljlipt8, r=Dylan-DPC
89e4e1f 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101598 (Update rustc's information on Android's sanitizers)
 - rust-lang#102036 (Remove use of `io::ErrorKind::Other` in std)
 - rust-lang#102037 (Make cycle errors recoverable)
 - rust-lang#102069 (Skip `Equate` relation in `handle_opaque_type`)
 - rust-lang#102076 (rustc_transmute: fix big-endian discriminants)
 - rust-lang#102107 (Add missing space between notable trait tooltip and where clause)
 - rust-lang#102119 (Fix a typo “pararmeter” in error message)
 - rust-lang#102131 (Added which number is computed in compute_float.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33b7ff1 into rust-lang:master Sep 22, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orlp @rust-highfive @rustbot @thomcc @bors @joshtriplett