Let expressions on RHS shouldn't be terminating scopes #103034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nathanwhit
force-pushed
the
let-chains-rhs-temporaries
branch
from
e0cc8ef
to
3041bc9
Compare
wesleywiser
approved these changes
Oct 18, 2022
|
Thanks @nathanwhit! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102863 (Standardize "use parentheses to call" suggestions between typeck and trait selection) - rust-lang#103034 (Let expressions on RHS shouldn't be terminating scopes) - rust-lang#103127 (Make transpose const and inline) - rust-lang#103153 (Allow `Vec::leak` when using `no_global_oom_handling`) - rust-lang#103182 (Clean up query descriptions) - rust-lang#103216 (Consider patterns in fn params in an `Elided(Infer)` lifetime rib.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100276.
Before this PR, we were unconditionally marking the RHS of short-circuiting binary expressions as a terminating scope.
In the case of a let chain where the
letexpression was on the RHS, this meant that temporaries within theletexpr would only live until the end of the expression. Since this only affected the RHS, this led to surprising behavior (example).After this PR, we only mark the RHS as a terminating scope if it is not a
letexpression.