Add some more autolabels #103204
Merged
Add some more autolabels #103204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 18, 2022
Add some more autolabels
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101889 (doc: rewrite doc for uint::{carrying_add,borrowing_sub}) - rust-lang#102507 (More slice::partition_point examples) - rust-lang#103164 (rustdoc: remove CSS ``@media` (min-width: 701px)`) - rust-lang#103189 (Clean up code-color and headers-color rustdoc GUI tests) - rust-lang#103203 (Retrieve LLVM version from llvm-filecheck binary if it is not set yet) - rust-lang#103204 (Add some more autolabels) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| @@ -203,6 +208,38 @@ trigger_files = [ | |||
| "compiler/rustc_macros/src/query.rs" | |||
| ] | |||
|
|
|||
| [autolabel."A-testsuite"] | |||
| trigger_files = [ | |||
| "src/test", | |||
There was a problem hiding this comment.
Can we remove this from the autolabel? This causes basically every compiler PR to be labeled A-testsuite, since almost every compiler PR has an associated UI test with it.
There was a problem hiding this comment.
Sure, makes sense. Not sure when I'll have time though.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 20, 2022
Don't label `src/test` tests as `A-testsuite` Nearly every PR modifies `src/test`; A-testsuite is meant to be for things affecting the test runners themselves. cc rust-lang#103204 (comment) r? `@jyn514`
m-ou-se
reviewed
Jan 14, 2023
| @@ -181,6 +181,11 @@ trigger_files = [ | |||
| "x.py", | |||
| "src/bootstrap", | |||
| "src/tools/rust-installer", | |||
| "configure", | |||
| "Cargo.toml", | |||
| "Cargo.lock", | |||
There was a problem hiding this comment.
Is this one supposed to be here? Adding any dependency to any rustc crate now makes the bot add the A-bootstrap label.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 17, 2023
Don't add A-bootstrap to PRs modifying Cargo.lock Changing Cargo.lock is common even when adding dependencies between existing rustc crates. cc rust-lang#103204 (comment), `@m-ou-se`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.