Remove structural match from `TypeId` #103291

raldone01 · 2022-10-20T06:31:54Z

Removing the structural equality might make sense, but is a breaking change that'd require a libs-api FCP.

Landing this PR now (well, mainly the "remove structural equality" part) would unblock const fn TypeId::of, since we only postponed that because we were guaranteeing too much.

See also #99189, #101698

rust-highfive · 2022-10-20T06:31:58Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-10-20T06:31:58Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

thomcc · 2022-10-20T06:33:58Z

I can't start that FCP and the comment is from @m-ou-se so....

r? @m-ou-se

raldone01 · 2022-10-20T06:37:28Z

@rustbot label +T-libs-api -T-libs

onestacked · 2022-10-20T06:37:52Z

cc @m-ou-se @eddyb

onestacked · 2022-11-15T11:49:37Z

@rustbot label +needs-fcp

src/test/ui/consts/issue-73976-monomorphic.rs

eddyb

LGTM but I don't understand what's going on with the test.

eddyb · 2022-11-28T09:14:18Z

Marking as blocked on:

Constify TypeId ordering impls #101698

raldone01 · 2023-02-03T19:14:22Z

@rustbot ready

WaffleLapkin · 2023-02-24T11:41:28Z

Is this waiting on libs FCP to be started?

onestacked · 2023-02-24T15:07:00Z

@m-ou-se and @eddyb wanted this, so i think yes.

bors · 2023-04-19T15:38:00Z

☔ The latest upstream changes (presumably #110393) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay

Thanks!

dtolnay · 2023-05-26T10:24:40Z

@bors r+

bors · 2023-05-26T10:24:43Z

📌 Commit 6827a41 has been approved by dtolnay

It is now in the queue for this repository.

…atch, r=dtolnay Remove structural match from `TypeId` As per rust-lang#99189 (comment). > Removing the structural equality might make sense, but is a breaking change that'd require a libs-api FCP. rust-lang#99189 (comment) > Landing this PR now (well, mainly the "remove structural equality" part) would unblock `const fn` `TypeId::of`, since we only postponed that because we were guaranteeing too much. See also rust-lang#99189, rust-lang#101698

bors · 2023-05-26T17:29:06Z

⌛ Testing commit 6827a41 with merge 1a5f8bc...

rfcbot · 2023-05-26T19:55:15Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

bors · 2023-05-26T20:04:48Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 1a5f8bc to master...

dtolnay · 2023-05-26T20:09:37Z

The pinnacle of efficiency. This must be a record?

rust-timer · 2023-05-26T21:21:40Z

Finished benchmarking commit (1a5f8bc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.8%, -1.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.1%, 4.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 643.928s -> 644.897s (0.15%)

rust-highfive assigned thomcc Oct 20, 2022

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 20, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022

rust-highfive assigned m-ou-se and unassigned thomcc Oct 20, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 20, 2022

rustbot added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Nov 15, 2022

eddyb reviewed Nov 28, 2022

View reviewed changes

src/test/ui/consts/issue-73976-monomorphic.rs Outdated Show resolved Hide resolved

eddyb approved these changes Nov 28, 2022

View reviewed changes

eddyb added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022

raldone01 force-pushed the typeid_no_struct_match branch from 7b92413 to a283c4f Compare February 3, 2023 19:02

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 3, 2023

raldone01 force-pushed the typeid_no_struct_match branch from a283c4f to dd57064 Compare February 3, 2023 20:26

WaffleLapkin removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 24, 2023

dtolnay approved these changes May 26, 2023

View reviewed changes

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 26, 2023

dtolnay assigned dtolnay and unassigned m-ou-se May 26, 2023

Dylan-DPC mentioned this pull request May 26, 2023

Rollup of 6 pull requests #111993

Closed

BoxyUwU mentioned this pull request May 26, 2023

TypeId exposes equality-by-subtyping vs normal-form-syntactic-equality unsoundness. #97156

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label May 26, 2023

bors merged commit 1a5f8bc into rust-lang:master May 26, 2023
11 checks passed

rustbot added this to the 1.71.0 milestone May 26, 2023

jbr mentioned this pull request May 27, 2023

Build failing on latest nightly async-rs/async-std#1058

Closed

This was referenced May 27, 2023

Error compiling using latest rust version algbio/ggcat#26

Closed

Compilation fails on nightly sval-rs/value-bag#62

Closed

CI is failing (Check Unused Dependencies) DigitalExtinction/Game#455

Closed

madsmtm mentioned this pull request May 27, 2023

Tracking Issue for const fn type_id #77125

Open

4 tasks

KodrAus mentioned this pull request May 29, 2023

ACP: Add const fn TypeId::matches for comparing type ids in consts rust-lang/libs-team#231

Closed

apiraino removed the to-announce Announce this issue on triage meeting label Jun 15, 2023

onestacked deleted the typeid_no_struct_match branch July 12, 2023 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove structural match from `TypeId` #103291

Remove structural match from `TypeId` #103291

raldone01 commented Oct 20, 2022 •

edited

Loading

rust-highfive commented Oct 20, 2022

rustbot commented Oct 20, 2022

thomcc commented Oct 20, 2022

raldone01 commented Oct 20, 2022

onestacked commented Oct 20, 2022

onestacked commented Nov 15, 2022

eddyb left a comment

eddyb commented Nov 28, 2022

raldone01 commented Feb 3, 2023

WaffleLapkin commented Feb 24, 2023

onestacked commented Feb 24, 2023

bors commented Apr 19, 2023

dtolnay left a comment

dtolnay commented May 26, 2023

bors commented May 26, 2023

bors commented May 26, 2023

rfcbot commented May 26, 2023

bors commented May 26, 2023

dtolnay commented May 26, 2023

rust-timer commented May 26, 2023

Remove structural match from TypeId #103291

Remove structural match from TypeId #103291

Conversation

raldone01 commented Oct 20, 2022 • edited Loading

rust-highfive commented Oct 20, 2022

rustbot commented Oct 20, 2022

thomcc commented Oct 20, 2022

raldone01 commented Oct 20, 2022

onestacked commented Oct 20, 2022

onestacked commented Nov 15, 2022

eddyb left a comment

Choose a reason for hiding this comment

eddyb commented Nov 28, 2022

raldone01 commented Feb 3, 2023

WaffleLapkin commented Feb 24, 2023

onestacked commented Feb 24, 2023

bors commented Apr 19, 2023

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented May 26, 2023

bors commented May 26, 2023

bors commented May 26, 2023

rfcbot commented May 26, 2023

bors commented May 26, 2023

dtolnay commented May 26, 2023

rust-timer commented May 26, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Remove structural match from `TypeId` #103291

Remove structural match from `TypeId` #103291

raldone01 commented Oct 20, 2022 •

edited

Loading