Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: Bring back ninja for dist builders" #103846

Merged
merged 1 commit into from Nov 3, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Nov 1, 2022

Reverts #103295 because of the perf regression.

r? @cuviper

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 1, 2022
@cuviper
Copy link
Member

cuviper commented Nov 1, 2022

Let's just confirm that first...

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 1, 2022
@bors
Copy link
Contributor

bors commented Nov 1, 2022

⌛ Trying commit f00d2c9 with merge 88fcf1daccbd4a70c6efec86182836968dab55d9...

@bors
Copy link
Contributor

bors commented Nov 2, 2022

☀️ Try build successful - checks-actions
Build commit: 88fcf1daccbd4a70c6efec86182836968dab55d9 (88fcf1daccbd4a70c6efec86182836968dab55d9)

@rust-timer
Copy link
Collaborator

Queued 88fcf1daccbd4a70c6efec86182836968dab55d9 with parent ab5a2bc, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (88fcf1daccbd4a70c6efec86182836968dab55d9): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-7.4%, -0.2%] 25
Improvements ✅
(secondary)
-2.0% [-6.7%, -0.2%] 74
All ❌✅ (primary) -1.4% [-7.4%, -0.2%] 25

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-7.4% [-7.8%, -6.6%] 4
Improvements ✅
(secondary)
-3.5% [-6.5%, -0.9%] 36
All ❌✅ (primary) -7.4% [-7.8%, -6.6%] 4

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 2, 2022
@cuviper
Copy link
Member

cuviper commented Nov 2, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2022

📌 Commit f00d2c9 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2022
@bors
Copy link
Contributor

bors commented Nov 2, 2022

⌛ Testing commit f00d2c9 with merge 5b1304a...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 5b1304a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2022
@bors bors merged commit 5b1304a into rust-lang:master Nov 3, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 3, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5b1304a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
-1.5% [-7.4%, -0.2%] 22
Improvements ✅
(secondary)
-2.0% [-6.6%, -0.2%] 71
All ❌✅ (primary) -1.5% [-7.4%, -0.2%] 22

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)
-3.2% [-4.4%, -2.0%] 2
All ❌✅ (primary) -3.2% [-3.2%, -3.2%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-6.7% [-7.6%, -5.9%] 4
Improvements ✅
(secondary)
-3.5% [-7.1%, -0.9%] 33
All ❌✅ (primary) -6.7% [-7.6%, -5.9%] 4

@Kobzol Kobzol deleted the revert-103295-ninja branch February 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants