Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE when negative impl is collected during eager mono #103950

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix ICE when negative impl is collected during eager mono #103950

merged 1 commit into from
Nov 4, 2022

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Nov 4, 2022 

trait Foo {
    fn foo() {}
}

impl !Foo for () {}

This code will currently cause an ICE when mono collection mode is "eager" (with -C link-dead-code=y or -Z print-mono-items=eager.

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2022
@tmiasko
Copy link
Contributor

tmiasko commented Nov 4, 2022

Thanks.
@bors r+

Looks like it should fix #101930 and #102730.

@bors
Copy link
Contributor

bors commented Nov 4, 2022

📌 Commit 1013ee8 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2022
@bors
Auto merge of rust-lang#103962 - matthiaskrgr:rollup-9av8i6k, r=matth…
6330c27 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103680 (CStr: add some doc links)
 - rust-lang#103780 (Fix late-bound lifetime closure ICEs in HIR typeck and MIR borrowck)
 - rust-lang#103845 (Add track_caller to some Lock methods)
 - rust-lang#103935 (Remove rustdoc clean::Visibility type)
 - rust-lang#103941 (Fixed typos)
 - rust-lang#103950 (Fix ICE when negative impl is collected during eager mono)
 - rust-lang#103953 (Remove unused argument from `throw_unresolved_import_error`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee3c9f7 into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
This was referenced Nov 9, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nbdd0121 @rustbot @tmiasko @bors @cjgillot