Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustdoc clean::Visibility type #103935

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove rustdoc clean::Visibility type #103935

merged 1 commit into from
Nov 4, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 3, 2022 •
edited

Fixes #90852.

Follow-up of #103690.

This PR completely removes the rustdoc clean::Visibility type to use the rustc_middle one instead. I don't think there will be any impact on perf.

r? @notriddle

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 3, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2022
@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Trying commit df32694 with merge 74b4d5fe1d0407440666876c9f4af0821043de41...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

☀️ Try build successful - checks-actions
Build commit: 74b4d5fe1d0407440666876c9f4af0821043de41 (74b4d5fe1d0407440666876c9f4af0821043de41)

@rust-timer
Copy link
Collaborator

Queued 74b4d5fe1d0407440666876c9f4af0821043de41 with parent 160b194, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (74b4d5fe1d0407440666876c9f4af0821043de41): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-2.8%, -0.4%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.1% [2.5%, 5.1%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2022
@GuillaumeGomez
Copy link
Member Author

I'm surprised there is an improvement. Oh well. Positive surprise.

@bors: r=notriddle rollup=iffy

@bors
Copy link
Contributor

bors commented Nov 3, 2022

📌 Commit df32694 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@notriddle
Copy link
Contributor

@GuillaumeGomez It's not real. All of the benchmarks showing a change are for targets that aren't doc.

@GuillaumeGomez
Copy link
Member Author

Ah perfect!

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2022
@bors
Auto merge of rust-lang#103962 - matthiaskrgr:rollup-9av8i6k, r=matth…
6330c27 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103680 (CStr: add some doc links)
 - rust-lang#103780 (Fix late-bound lifetime closure ICEs in HIR typeck and MIR borrowck)
 - rust-lang#103845 (Add track_caller to some Lock methods)
 - rust-lang#103935 (Remove rustdoc clean::Visibility type)
 - rust-lang#103941 (Fixed typos)
 - rust-lang#103950 (Fix ICE when negative impl is collected during eager mono)
 - rust-lang#103953 (Remove unused argument from `throw_unresolved_import_error`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c6e5150 into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
@GuillaumeGomez GuillaumeGomez deleted the remove-rustdoc-visibility-ty branch November 4, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

rustdoc: Compute visibility on-demand, using ty::Visibility
5 participants
@GuillaumeGomez @rustbot @rust-timer @bors @notriddle