Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statics used in reachable function's inline asm are reachable #105023

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Statics used in reachable function's inline asm are reachable #105023

merged 1 commit into from
Nov 30, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Nov 28, 2022

Fixes #104925.

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2022

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2022
@tmiasko tmiasko added the A-inline-assembly Area: Inline assembly (`asm!(…)`) label Nov 28, 2022
@wesleywiser
Copy link
Member

r? @wesleywiser

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 63915be has been approved by wesleywiser

It is now in the queue for this repository.

@rustbot rustbot assigned wesleywiser and unassigned oli-obk Nov 28, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
@luqmana
Copy link
Member

luqmana commented Nov 28, 2022

asm_sym has been stabilized as of 1.66 which is current beta. Given this is a rather small patch worth backporting?

@wesleywiser
Copy link
Member

Yeah, thanks @luqmana! I didn't realize that had been stabilized in beta.

Nominating for beta-backport to ride the release train with #103168.

@wesleywiser wesleywiser added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 28, 2022
@shamatar shamatar mentioned this pull request Nov 28, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#105023 - tmiasko:asm-sym-static-reachable, …
1505fc0 
…r=wesleywiser

Statics used in reachable function's inline asm are reachable

Fixes rust-lang#104925.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
@bors
Auto merge of rust-lang#105070 - matthiaskrgr:rollup-9b25khj, r=matth…
d38a990 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
 - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible)
 - rust-lang#104436 (Add slice to the stack allocated string comment)
 - rust-lang#104523 (Don't use periods in target names)
 - rust-lang#104627 (Print all features with --print target-features)
 - rust-lang#104911 (Make inferred_outlives_crate return Clause)
 - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`)
 - rust-lang#105023 (Statics used in reachable function's inline asm are reachable)
 - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns)
 - rust-lang#105049 (Hermit: Minor build fixes)
 - rust-lang#105051 (Replace a macro with a function)
 - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
 - rust-lang#105066 (move `candidate_from_obligation` out of assembly)
 - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

 - rust-lang#105050 (Remove useless borrows and derefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 581ca3e into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
@tmiasko tmiasko deleted the asm-sym-static-reachable branch November 30, 2022 20:15
@apiraino
Copy link
Contributor

apiraino commented Dec 1, 2022

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 1, 2022
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 11, 2022
@pietroalbini pietroalbini mentioned this pull request Dec 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2022
@bors
Auto merge of rust-lang#105563 - pietroalbini:pa-stable-1.66.0, r=pie…
69f9c33 
…troalbini

[stable] Prepare 1.66.0 release

This PR prepares the artifacts for the 1.66.0 release. The following PRs have been backported:

* rust-lang#104782
* rust-lang#105023
* rust-lang#104558
* rust-lang#104610
* rust-lang#103989
* rust-lang#104650
* rust-lang#105539
* rust-lang#105477

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Failed linking to a library that uses inline assembly with asm_sym feature
8 participants
@tmiasko @rustbot @wesleywiser @bors @luqmana @apiraino @oli-obk @pietroalbini