Skip to content

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Dec 12, 2022

Fixes #105429

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2022
@TaKO8Ki TaKO8Ki force-pushed the suggest-dereferencing-receiver-argument branch from 6dd34c6 to 5ebf8ef Compare December 13, 2022 18:23
@compiler-errors
Copy link
Member

Thanks

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 13, 2022

📌 Commit 5ebf8ef31cf3b0474047b28089a58145d5b6ca76 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned cjgillot Dec 13, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
@TaKO8Ki TaKO8Ki force-pushed the suggest-dereferencing-receiver-argument branch from 5ebf8ef to 19fa5b3 Compare December 13, 2022 18:50
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Dec 13, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Dec 13, 2022

📌 Commit 19fa5b3 has been approved by compiler-errors

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2022
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103644 (Add docs for question mark operator for Option)
 - rust-lang#105161 (Refine when invalid prefix case error arises)
 - rust-lang#105491 (Illegal sized bounds: only suggest mutability change if needed)
 - rust-lang#105502 (Suggest impl in the scenario of typo with fn)
 - rust-lang#105523 (Suggest `collect`ing into `Vec<_>`)
 - rust-lang#105595 (Suggest dereferencing receiver arguments properly)
 - rust-lang#105611 (fold instead of obliterating args)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 939880a into rust-lang:master Dec 14, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 14, 2022
@TaKO8Ki TaKO8Ki deleted the suggest-dereferencing-receiver-argument branch December 14, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"consider dereferencing here" help doesn't account for operator precedence of the deref operator
5 participants