Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type flags support for Ty and Const late-bound variables #105733

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

compiler-errors
Copy link
Member

I've been working on for<T> binders, and these will eventually be useful.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2022
@bors
Copy link
Contributor

bors commented Dec 15, 2022

⌛ Trying commit d2ef902bd7dbc6ee89ea5efc685a6b3aa37149de with merge 0bc47f1d657456dfa37c363688b7d3f1b19ac8a0...

@compiler-errors compiler-errors changed the title Add type flags support for Ty and Const late-bound regions Add type flags support for Ty and Const late-bound variables Dec 15, 2022
@bors
Copy link
Contributor

bors commented Dec 15, 2022

☀️ Try build successful - checks-actions
Build commit: 0bc47f1d657456dfa37c363688b7d3f1b19ac8a0 (0bc47f1d657456dfa37c363688b7d3f1b19ac8a0)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0bc47f1d657456dfa37c363688b7d3f1b19ac8a0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2022
@cjgillot
Copy link
Contributor

Could you elaborate the use case for these for<T> binders? Predicates only, or do you have plans to have them in types too?

@compiler-errors
Copy link
Member Author

@cjgillot yeah, predicates are probably the only place they make sense in the language currently.

@cjgillot
Copy link
Contributor

cjgillot commented Jan 7, 2023

r=me with @fbstj's suggestion applied.

@compiler-errors
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Jan 8, 2023

📌 Commit 3c41003 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2023
@bors
Copy link
Contributor

bors commented Jan 8, 2023

⌛ Testing commit 3c41003 with merge a8686e450a79735ad18881a34475383b5dcd059f...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 8, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2023
@compiler-errors
Copy link
Member Author

@bors retry

That test timeout looks spurious?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2023
@bors
Copy link
Contributor

bors commented Jan 8, 2023

⌛ Testing commit 3c41003 with merge e6485ed...

@bors
Copy link
Contributor

bors commented Jan 8, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing e6485ed to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2023
@bors bors merged commit e6485ed into rust-lang:master Jan 8, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 8, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e6485ed): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-3.0%, -2.1%] 3
All ❌✅ (primary) - - 0

@compiler-errors compiler-errors deleted the ty-ct-late-flags branch August 11, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants