Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-installer #106196

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Bump rust-installer #106196

merged 1 commit into from
Dec 29, 2022

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Dec 27, 2022

--without=component-a,component-b now requires full component names. This fixes #105755 (rust-lang/rust-installer#119).

dev-static build succeeded, and installer script seems to work (see comment in thread).

* `--without=component-a,component-b` now requires full component names.
  This fixes rust-lang#105755 (rust-lang/rust-installer#119).
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 27, 2022

⌛ Trying commit 0018bcc with merge cc0c754eab6dc84b862b1922c6cf4a991aff82f4...

@bors
Copy link
Contributor

bors commented Dec 28, 2022

☀️ Try build successful - checks-actions
Build commit: cc0c754eab6dc84b862b1922c6cf4a991aff82f4 (cc0c754eab6dc84b862b1922c6cf4a991aff82f4)

@Mark-Simulacrum
Copy link
Member Author

dev-static looks successful.

$ ./install.sh --prefix=`pwd`/installed --without=rust-docs-json-preview,rust-analyzer-preview
install: creating uninstall script at /home/mark/Edit/rust/rust-nightly-x86_64-unknown-linux-gnu/installed/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-x86_64-unknown-linux-gnu'
install: installing component 'rust-docs'
install: installing component 'rust-demangler-preview'
install: installing component 'cargo'
install: installing component 'rustfmt-preview'
install: installing component 'rls-preview'
install: installing component 'llvm-tools-preview'
install: installing component 'clippy-preview'
install: installing component 'miri-preview'
install: installing component 'rust-analysis-x86_64-unknown-linux-gnu'
install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error

    rust installed.

@jyn514
Copy link
Member

jyn514 commented Dec 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 28, 2022

📌 Commit 0018bcc has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2022
@bors
Copy link
Contributor

bors commented Dec 29, 2022

⌛ Testing commit 0018bcc with merge 29d76cc...

@bors
Copy link
Contributor

bors commented Dec 29, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 29d76cc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2022
@bors bors merged commit 29d76cc into rust-lang:master Dec 29, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (29d76cc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.1% [2.8%, 3.4%] 2
Regressions ❌
(secondary)
2.3% [0.8%, 3.9%] 24
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.1% [2.8%, 3.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@Mark-Simulacrum Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 30, 2022
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 12, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.68.0, 1.67.0 Jan 19, 2023
@Mark-Simulacrum Mark-Simulacrum deleted the bump-installer branch January 19, 2023 14:14
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
…mulacrum

[beta] backport rollup

* Revert "Make nested RPITIT inherit the parent opaque's generics." rust-lang#106759
*  Fix mpsc::SyncSender spinning behavior rust-lang#106701
*  rustdoc: fix outdated lint section of the book rust-lang#106605
*  Do not filter substs in remap_generic_params_to_declaration_params. rust-lang#106503
*  Correct detection of elided lifetimes in impl-trait. rust-lang#106501
*  Bump rust-installer rust-lang#106196
*  Don't panic on stable since miri is not available there rust-lang#105901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust 1.66.0 install.sh fails when --without flag is used
5 participants