make `output_filenames` a real query #106812

oli-obk · 2023-01-13T14:42:29Z

This may be a perf regression and is not obviously the right way forward. We may store this information in the resolver after freezing it for example.

oli-obk · 2023-01-13T14:42:42Z

@bors try @rust-timer queue

bors · 2023-01-13T14:42:52Z

⌛ Trying commit 2662e08b3a48936e957dd4df823661b58ae7491f with merge d38ca7daa122b6e00905155cee03302da88c8c12...

bors · 2023-01-13T17:11:23Z

☀️ Try build successful - checks-actions
Build commit: d38ca7daa122b6e00905155cee03302da88c8c12 (d38ca7daa122b6e00905155cee03302da88c8c12)

rust-timer · 2023-01-13T20:58:03Z

Finished benchmarking commit (d38ca7daa122b6e00905155cee03302da88c8c12): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.4%]	4
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	4
Improvements ✅ (secondary)	-0.7%	[-1.0%, -0.2%]	3
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[1.1%, 4.2%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-3.0%, -1.0%]	6
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

rustbot · 2023-01-19T08:09:51Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

oli-obk · 2023-01-19T08:10:08Z

r? @petrochenkov

compiler/rustc_driver/src/lib.rs

compiler/rustc_interface/src/lib.rs

compiler/rustc_interface/src/passes.rs

compiler/rustc_middle/src/ty/mod.rs

oli-obk · 2023-01-19T15:20:02Z

@rustbot ready

compiler/rustc_interface/src/passes.rs

oli-obk · 2023-01-23T14:22:52Z

@bors r=petrochenkov

bors · 2023-01-23T14:22:54Z

📌 Commit d924a8c has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-01-23T21:59:02Z

⌛ Testing commit d924a8c with merge aaf4becd9f99cbeb61727d9c085ac6711cb2cef5...

bors · 2023-01-24T02:14:02Z

💥 Test timed out

petrochenkov · 2023-01-24T06:13:09Z

@bors retry

rust-log-analyzer · 2023-01-24T13:50:29Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2023-01-26T20:32:31Z

⌛ Testing commit d924a8c with merge d7948c8...

bors · 2023-01-27T00:03:02Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d7948c8 to master...

bors · 2023-01-27T00:03:02Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d7948c8 to master...

rust-timer · 2023-01-27T01:21:25Z

Finished benchmarking commit (d7948c8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[0.6%, 6.8%]	7
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-2.4%	[-2.9%, -1.8%]	3
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-	-	0

…rochenkov give the resolver access to TyCtxt The resolver is now created after TyCtxt is created. Then macro expansion and name resolution are run and the results fed into queries just like before this PR. Since the resolver had (before this PR) mutable access to the `CStore` and the source span table, these two datastructures are now behind a `RwLock`. To ensure that these are not mutated anymore after the resolver is done, a read lock to them is leaked right after the resolver finishes. ### PRs split out of this one and leading up to it: * rust-lang#105423 * rust-lang#105357 * rust-lang#105603 * rust-lang#106776 * rust-lang#106810 * rust-lang#106812 * rust-lang#108032

give the resolver access to TyCtxt The resolver is now created after TyCtxt is created. Then macro expansion and name resolution are run and the results fed into queries just like before this PR. Since the resolver had (before this PR) mutable access to the `CStore` and the source span table, these two datastructures are now behind a `RwLock`. To ensure that these are not mutated anymore after the resolver is done, a read lock to them is leaked right after the resolver finishes. ### PRs split out of this one and leading up to it: * rust-lang/rust#105423 * rust-lang/rust#105357 * rust-lang/rust#105603 * rust-lang/rust#106776 * rust-lang/rust#106810 * rust-lang/rust#106812 * rust-lang/rust#108032

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 13, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 13, 2023

oli-obk mentioned this pull request Jan 13, 2023

give the resolver access to TyCtxt #105462

Merged

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 13, 2023

This comment has been minimized.

Sign in to view

oli-obk force-pushed the output_filenames branch 2 times, most recently from ed365ad to 89ad8fa Compare January 17, 2023 09:50

This comment has been minimized.

Sign in to view

oli-obk force-pushed the output_filenames branch from 89ad8fa to 7cc499b Compare January 19, 2023 08:08

oli-obk marked this pull request as ready for review January 19, 2023 08:09

rustbot assigned petrochenkov Jan 19, 2023

petrochenkov reviewed Jan 19, 2023

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2023

petrochenkov reviewed Jan 19, 2023

View reviewed changes

compiler/rustc_interface/src/passes.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2023

Evaluate output_filenames before one of its dependencies gets stolen

d924a8c

oli-obk force-pushed the output_filenames branch from 4310c49 to d924a8c Compare January 23, 2023 14:22

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2023

bors merged commit d7948c8 into rust-lang:master Jan 27, 2023

rustbot added this to the 1.69.0 milestone Jan 27, 2023

rustbot removed the perf-regression Performance regression. label Jan 27, 2023

oli-obk deleted the output_filenames branch January 27, 2023 07:07

tedinski mentioned this pull request Feb 3, 2023

Update Rust toolchain to nightly-2023-02-03 model-checking/kani#2184

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make `output_filenames` a real query #106812

make `output_filenames` a real query #106812

oli-obk commented Jan 13, 2023 •

edited

Loading

oli-obk commented Jan 13, 2023

This comment has been minimized.

bors commented Jan 13, 2023

bors commented Jan 13, 2023

This comment has been minimized.

rust-timer commented Jan 13, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Jan 19, 2023

oli-obk commented Jan 19, 2023

oli-obk commented Jan 19, 2023

oli-obk commented Jan 23, 2023

bors commented Jan 23, 2023

bors commented Jan 23, 2023

bors commented Jan 24, 2023

petrochenkov commented Jan 24, 2023

rust-log-analyzer commented Jan 24, 2023

bors commented Jan 26, 2023

bors commented Jan 27, 2023

bors commented Jan 27, 2023

rust-timer commented Jan 27, 2023

make output_filenames a real query #106812

make output_filenames a real query #106812

Conversation

oli-obk commented Jan 13, 2023 • edited Loading

oli-obk commented Jan 13, 2023

This comment has been minimized.

bors commented Jan 13, 2023

bors commented Jan 13, 2023

This comment has been minimized.

rust-timer commented Jan 13, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

This comment has been minimized.

This comment has been minimized.

rustbot commented Jan 19, 2023

oli-obk commented Jan 19, 2023

oli-obk commented Jan 19, 2023

oli-obk commented Jan 23, 2023

bors commented Jan 23, 2023

bors commented Jan 23, 2023

bors commented Jan 24, 2023

petrochenkov commented Jan 24, 2023

rust-log-analyzer commented Jan 24, 2023

bors commented Jan 26, 2023

bors commented Jan 27, 2023

bors commented Jan 27, 2023

rust-timer commented Jan 27, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

make `output_filenames` a real query #106812

make `output_filenames` a real query #106812

oli-obk commented Jan 13, 2023 •

edited

Loading