Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test where we ignore hr implied bounds #107255

Merged
merged 1 commit into from
Jan 26, 2023
Merged

add test where we ignore hr implied bounds #107255

merged 1 commit into from
Jan 26, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 24, 2023

r? types

@lcnr lcnr marked this pull request as ready for review January 24, 2023 11:42
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jan 24, 2023

Can you add a variant of the test that should keep failing if that one starts passing?

@lcnr
Copy link
Contributor Author

lcnr commented Jan 24, 2023

hmm, not sure what such a test would look like 🤔 the note "We have to be careful as implied bounds are only sound if they're also correctly checked" was more about implied bounds in general and includes stuff like #25860, #84591, and #100051.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 24, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 24, 2023

📌 Commit e6e93e0 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 24, 2023

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2023
@the8472
Copy link
Member

the8472 commented Jan 24, 2023 •
edited
Loading

Can you add a variant of the test that should keep failing if that one starts passing?

There is the should-fail directive for that. (nvm that's for panics) And if you don't want to check the error output then there's a known-bug directive

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#107255 - lcnr:implied-b-hr, r=oli-obk
bd2b2ca 
add test where we ignore hr implied bounds

r? types
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 25, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#107255 - lcnr:implied-b-hr, r=oli-obk
7cebffe 
add test where we ignore hr implied bounds

r? types
This was referenced Jan 25, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2023
@bors
Auto merge of rust-lang#107309 - matthiaskrgr:rollup-0wgq6be, r=matth…
2a17174 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#105345 (Add hint for missing lifetime bound on trait object when type alias is used)
 - rust-lang#106897 (Tweak E0597)
 - rust-lang#106944 (Suggest using a lock for `*Cell: Sync` bounds)
 - rust-lang#107239 (Bring tests back into rustc source tarball)
 - rust-lang#107244 (rustdoc: rearrange HTML in primitive reference links)
 - rust-lang#107255 (add test where we ignore hr implied bounds)
 - rust-lang#107256 (Delete `SimplifyArmIdentity` and `SimplifyBranchSame` mir opts)
 - rust-lang#107266 (rustdoc: prohibit scroll bar on source viewer in Safari)
 - rust-lang#107282 (erica solver: implement builtin `Pointee` trait impl candidates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c20e0da into rust-lang:master Jan 26, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 26, 2023
@lcnr lcnr deleted the implied-b-hr branch January 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @oli-obk @bors @the8472 @rustbot