Pass DepContext and QueryContext by value when practical

[Zoxc]

This removes some indirections for a minor performance improvement.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.8294s	1.8255s	-0.21%
🟣 hyper:check	0.2667s	0.2669s	0.07%
🟣 regex:check	1.0080s	1.0063s	-0.17%
🟣 syn:check	1.6335s	1.6295s	-0.24%
🟣 syntex_syntax:check	6.3633s	6.3344s	-0.45%
Total	11.1009s	11.0627s	-0.34%
Summary	1.0000s	0.9980s	-0.20%

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

r=me if perf is green.

[bors]

⌛ Trying commit b3a4fe7 with merge 1743e75d256ff90f58bdd38a087532b36b9d731f...

[Noratrieb]

Interesting that this is also a perf improvement (well, maybe the pgo pipeline makes it go away), guess it doess make sense, I've wanted to this for cleanup reasons for a while :D

[bors]

☀️ Try build successful - checks-actions
Build commit: 1743e75d256ff90f58bdd38a087532b36b9d731f (1743e75d256ff90f58bdd38a087532b36b9d731f)

[rust-timer]

Finished benchmarking commit (1743e75d256ff90f58bdd38a087532b36b9d731f): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	6.5%	[6.5%, 6.5%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-2.5%	[-2.7%, -2.3%]	8
All ❌✅ (primary)	-0.3%	[-2.8%, 2.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

[cjgillot]

@bors r+

[bors]

📌 Commit b3a4fe7 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit b3a4fe7 with merge cd3299127ac7eff581dd6b48fe3e0ca2216eb3a4...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

 Copying stage0 library from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
[TIMING] compile::StdLink { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu, crates: [] } -- 0.000
[TIMING] compile::Std { target: x86_64-unknown-linux-gnu, compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, crates: [] } -- 44.937
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/47c0792aaa74e30615e237de57e895de8af16578/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
curl: (22) The requested URL returned error: 404 

Spurious?

@bors retry spurious 404

[rust-log-analyzer]

The job wasm32 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

curl: (22) The requested URL returned error: 404 

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:


    [llvm]
    download-ci-llvm = false

[bors]

⌛ Testing commit b3a4fe7 with merge b5c8c32...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing b5c8c32 to master...

[rust-timer]

Finished benchmarking commit (b5c8c32): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0